fix(ACI): Update tests to use 'any-short' logic type for trigger conditions#108257
Merged
NicoHinderling merged 1 commit intomasterfrom Feb 13, 2026
Merged
fix(ACI): Update tests to use 'any-short' logic type for trigger conditions#108257NicoHinderling merged 1 commit intomasterfrom
NicoHinderling merged 1 commit intomasterfrom
Conversation
…itions Tests missed in fe7b9ff that added validation requiring trigger conditions to use 'any-short' logic type. The validation in BaseDataConditionGroupValidator.create() also applies to action filter DCGs containing trigger condition types like first_seen_event. Co-Authored-By: Claude <noreply@anthropic.com>
ceorourke
approved these changes
Feb 13, 2026
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
That should do it, sorry idk how that happened. Thanks for the quick fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests were missed in fe7b9ff (#107548) which added validation requiring
trigger conditions to use
any-shortlogic type. The_validate_logic_typecheck in
BaseDataConditionGroupValidator.create()fires for all DCGs(triggers and action filters) when conditions contain trigger condition types
like
first_seen_event.Failing tests:
test_create_trigger_condition_from_different_organization— trigger withlogicType: "any"test_create_action_filter_condition_from_different_organization— action filter withlogicType: "any"andfirst_seen_eventconditiontest_update_action_filter_condition_from_different_organization— same as above in update pathFix: change
logicTypefrom"any"to"any-short"in all three test payloads.