fix(hybridcloud): Use distribution metric for webhook delivery time#108289
Merged
fix(hybridcloud): Use distribution metric for webhook delivery time#108289
Conversation
Replace `metrics.timing()` with `metrics.distribution()` for delivery time. `timing()` expects milliseconds but we were passing seconds, so values were wrong by a factor of 1000. `distribution()` with unit="millisecond" is explicit and correct. We also add a tag to track where the webhook is sent to.
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
armenzg
commented
Feb 14, 2026
| if payload.destination_type == DestinationType.SENTRY_REGION | ||
| else "codecov" | ||
| ) | ||
| tags = {"region_sent_to": region_sent_to} |
| duration = timezone.now() - payload_record.date_added | ||
| _record_delivery_time_metrics(payload_record) | ||
| metrics.incr("hybridcloud.deliver_webhooks.delivery", tags={"outcome": "ok"}) | ||
| metrics.timing("hybridcloud.deliver_webhooks.delivery_time", duration.total_seconds()) |
Member
Author
There was a problem hiding this comment.
We're replacing this metric which expects milliseconds yet we have been passing seconds.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
markstory
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
metrics.timing()withmetrics.distribution()for delivery time.timing()expects milliseconds but we were passing seconds, so values were wrong by a factor of 1000.distribution()withunit="millisecond"is explicit and correct.We also add a tag to track where the webhook is sent to.