feat(dashboards): add text widget visualization and integrate into viewer modal#108539
Open
nikkikapadia wants to merge 3 commits intomasterfrom
Open
feat(dashboards): add text widget visualization and integrate into viewer modal#108539nikkikapadia wants to merge 3 commits intomasterfrom
nikkikapadia wants to merge 3 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| description={widget.description} | ||
| description={ | ||
| widget.displayType === DisplayType.TEXT ? undefined : widget.description | ||
| } |
Contributor
There was a problem hiding this comment.
Text widget description shown in wrong card path
Medium Severity
Text widgets always use the second render path (when canUseTimeseriesVisualization is false) but the description-hiding logic for text widgets was only added to the first path. The second path still passes widget.description to WidgetFrame, so text widgets show the description in the frame header while the body also renders it via TextWidgetVisualization, causing duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the text visualization component which is just a
MarkedTextcomponent within formatting containers. I've integrated it into the widget card components so that it will be baked in whenever someone uses the widget components. To make sure it has all the functionality (at least in dashboards) i've also made it compatible with the widget viewer modal. Here's some proof: