Skip to content

ref(uptime): Prefix uptime assertion-related type exports with Uptime#108562

Merged
jaydgoss merged 2 commits into
masterfrom
jaygoss/uptime-prefix-assertion-types
Feb 25, 2026
Merged

ref(uptime): Prefix uptime assertion-related type exports with Uptime#108562
jaydgoss merged 2 commits into
masterfrom
jaygoss/uptime-prefix-assertion-types

Conversation

@jaydgoss
Copy link
Copy Markdown
Member

Summary

Test plan

  • TypeScript typecheck passes cleanly
  • All 177 tests pass across 15 spec files (assertions, suggestions, forms, alert form)
  • ESLint and prettier pass

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 19, 2026
@jaydgoss jaydgoss marked this pull request as ready for review February 19, 2026 19:51
@jaydgoss jaydgoss requested review from a team as code owners February 19, 2026 19:51
@jaydgoss jaydgoss changed the title ref(uptime): Prefix assertion-related exports with Uptime ref(uptime): Prefix uptime assertion-related exports with Uptime Feb 19, 2026
@jaydgoss jaydgoss changed the title ref(uptime): Prefix uptime assertion-related exports with Uptime ref(uptime): Prefix uptime assertion-related type exports with Uptime Feb 19, 2026
@jaydgoss jaydgoss force-pushed the jaygoss/uptime-prefix-assertion-types branch from fb15e35 to d383674 Compare February 19, 2026 21:23
@jaydgoss jaydgoss requested a review from Abdkhan14 February 23, 2026 16:47
@jaydgoss jaydgoss force-pushed the jaygoss/new-751-add-enums-for-assertion_type-and-comparison-in-uptime branch from af3f9ac to fc2b138 Compare February 23, 2026 17:12
@jaydgoss jaydgoss force-pushed the jaygoss/uptime-prefix-assertion-types branch from d383674 to ccb9105 Compare February 23, 2026 17:13
Base automatically changed from jaygoss/new-751-add-enums-for-assertion_type-and-comparison-in-uptime to master February 23, 2026 17:27
…ming collisions

Renames all assertion-related type exports in the uptime types file to
include an Uptime prefix (e.g. Op -> UptimeOp, Assertion -> UptimeAssertion,
ComparisonType -> UptimeComparisonType). This prevents naming collisions
when these types are imported elsewhere in the codebase.
… fields.spec.tsx

Two OpType.AND references at lines 297 and 323 were missed during the
rebase because they were in a different section of the file than the
base branch's fix, so git auto-merged without conflict.
@jaydgoss jaydgoss merged commit 8f7f842 into master Feb 25, 2026
63 checks passed
@jaydgoss jaydgoss deleted the jaygoss/uptime-prefix-assertion-types branch February 25, 2026 18:48
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants