chore: remove graduated feature flags (data-browsing batch 6)#108801
Conversation
…metrics-saved-queries, tracemetrics-set-project-flag, tracemetrics-stats, tracing-export-csv) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
narsaynorath
left a comment
narsaynorath
left a comment
There was a problem hiding this comment.
My only suggestion is that the hooks, e.g. useHasTraceMetricsDashboards, can be removed or their callsites simplified if the hooks no longer need to be around. I can clean that up in another PR later if we just want to get this in to remove the flag and enable it as default behaviour
The hook was reduced to `return true` after the flag removal. Remove it entirely and inline the true value / remove conditionals at all 5 callsites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ], | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Metrics dashboard action no longer gated
Medium Severity
addToDashboardItems is now always returned, even when canUseMetricsSavedQueriesUI(organization) is false. This can surface the “Dashboard widget” submenu in contexts where metrics features are effectively disabled, leading to UI actions that can error (e.g., 403s) or create confusing dead-end behavior.
| <SpansExport | ||
| aggregatesTableResult={aggregatesTableResult} | ||
| spansTableResult={spansTableResult} | ||
| /> |
There was a problem hiding this comment.
CSV export shown without backend capability check
Medium Severity
SpansExport is no longer wrapped by Feature features="organizations:tracing-export-csv". If any server/API permissioning still relies on that feature (or an equivalent capability), the UI will now expose export controls that can fail at execution time.
## Summary Removes 4 feature flags owned by data-browsing that have been enabled at 100% via flagpole with no conditions: - `organizations:tracemetrics-dashboards` - `organizations:tracemetrics-saved-queries` - `organizations:tracemetrics-stats` - `organizations:tracing-export-csv` These flags have been fully rolled out and their behavior is now the default. ## Test plan - [ ] CI passes - [ ] Corresponding sentry-options-automator PR to remove flagpole config 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary Removes 4 feature flags owned by data-browsing that have been enabled at 100% via flagpole with no conditions: - `organizations:tracemetrics-dashboards` - `organizations:tracemetrics-saved-queries` - `organizations:tracemetrics-stats` - `organizations:tracing-export-csv` These flags have been fully rolled out and their behavior is now the default. ## Test plan - [ ] CI passes - [ ] Corresponding sentry-options-automator PR to remove flagpole config 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
Summary
Removes 4 feature flags owned by data-browsing that have been enabled at 100% via flagpole with no conditions:
organizations:tracemetrics-dashboardsorganizations:tracemetrics-saved-queriesorganizations:tracemetrics-statsorganizations:tracing-export-csvThese flags have been fully rolled out and their behavior is now the default.
Test plan
🤖 Generated with Claude Code