chore: remove graduated feature flags (data-browsing batch 7)#108802
Open
chore: remove graduated feature flags (data-browsing batch 7)#108802
Conversation
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
wedamija
force-pushed
the
flag-burner/ga/data-browsing-7
branch
from
daad948 to
d949bfd
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
|
@nicholas-codecov are the search builder flags safe to remove? |
…sampled-date-page-filter, search-query-builder-add-boolean-operator-select, search-query-builder-conditionals-combobox-menus, visibility-explore-equations) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
After removing the downsampled-date-page-filter flag check, both branches declared `const maxPickableDays` in the same scope. Since getMaxPickableDaysBySubscription already handles all cases covered by getLegacyMaxPickableDaysBySubscription, remove the legacy function and its call entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…cs marker Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- useMaxPickableDays: Add fake timers for spans tests since
getMaxPickableDaysBySubscription now always runs (was gated behind
downsampled-date-page-filter). Update expected values for profiles
(now 30/30 with defaultPeriod). Remove spans-with-flag test since
visibility-explore-range-high is no longer consulted in this path.
- cellAction/tableView/table: Replace getByRole('button', {name: 'Actions'})
with getByLabelText('Actions') since V2 cell actions use a div trigger
instead of a Button component.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wedamija
force-pushed
the
flag-burner/ga/data-browsing-7
branch
from
d949bfd to
fc27930
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
static/app/components/searchQueryBuilder/tokens/useSortedFilterKeyItems.tsx
Show resolved
Hide resolved
After removing the discover-cell-actions-v2 flag, the cell action trigger
changed from a Button to a div with aria-label="Actions". Updated test
selectors in indirectly affected spec files to use getByLabelText('Actions')
instead of getByRole('button'), and getByText instead of getByRole('cell')
for cells wrapped in the v2 action container.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 5 feature flags owned by data-browsing that have been enabled at 100% via flagpole:
organizations:discover-cell-actions-v2— Discover cell actions v2organizations:downsampled-date-page-filter— Downsampled date page filterorganizations:search-query-builder-add-boolean-operator-select— Search query builder boolean operator selectorganizations:search-query-builder-conditionals-combobox-menus— Search query builder conditionals combobox menusorganizations:visibility-explore-equations— Explore equations visibilityTest plan
🤖 Generated with Claude Code