fix(tests): Fix flaky test_generate_rule_conditions_filters ordering#108914
Draft
fix(tests): Fix flaky test_generate_rule_conditions_filters ordering#108914
Conversation
Use order-independent comparison for conditions and filters lists since the DB query order from `conditions.all()` is non-deterministic. Fixes #108913
Member
Author
|
can these be set-compared instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_generate_rule_conditions_filtersconditions.all()DB query order is non-deterministic, causing the==comparison to fail intermittently when conditions come back in a different orderassert_equal_serializersin the same fileFixes #108913