fix(tests): Fix flaky test_get_or_create_user non-deterministic ordering#108919
Draft
fix(tests): Fix flaky test_get_or_create_user non-deterministic ordering#108919
Conversation
Add explicit `order_by('id')` to the user query in `get_user_by_email`
so that when multiple users share the same email, the user with the
lowest ID is consistently returned. Without explicit ordering, the DB
may return users in any order making the "first user" non-deterministic.
Fixes #108910
github-actions
bot
added
the
Scope: Backend
Member
Author
|
ehh maybe we should not change this and instead adapt the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
order_by('id')to the user query inget_user_by_emailso that when multiple users share the same email, the user with the lowest ID is consistently returnedFixes #108910
Fixes #108925