feat(preprod): Add distribution state fields to PreprodArtifact (EME-842)#109075
Merged
runningcode merged 2 commits intomasterfrom Feb 24, 2026
Merged
feat(preprod): Add distribution state fields to PreprodArtifact (EME-842)#109075runningcode merged 2 commits intomasterfrom
runningcode merged 2 commits intomasterfrom
Conversation
…842) Add distribution_state and distribution_skip_reason columns to PreprodArtifact so we can record when build distribution is skipped (and why), matching the existing NOT_RAN pattern for size analysis.
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Add field installable_app_error_code to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "installable_app_error_code" integer NULL CHECK ("installable_app_error_code" >= 0);
--
-- Add field installable_app_error_message to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "installable_app_error_message" text NULL; |
chromy
reviewed
Feb 23, 2026
…(EME-842)
Per code review feedback, replace the distribution_state/distribution_skip_reason
fields with installable_app_error_code/installable_app_error_message following
the existing ErrorCode pattern on PreprodArtifact. This eliminates ambiguous
state combinations between distribution_state and installable_app_file_id:
- file_id set + no error_code → success ("available")
- no file_id + error_code set → skipped/failed ("not_ran")
- no file_id + no error_code → pending / not yet determined
chromy
reviewed
Feb 24, 2026
| (cls.NOT_RAN, "not_ran"), | ||
| (cls.UNKNOWN, "unknown"), | ||
| (cls.NO_QUOTA, "no_quota"), | ||
| (cls.SKIPPED, "skipped"), |
Contributor
There was a problem hiding this comment.
nit: and PROCESSING_ERROR or something for the launchpad case
Contributor
There was a problem hiding this comment.
(but we can add when it's used)
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…842) (#109075) ## Summary - Add `installable_app_error_code` and `installable_app_error_message` columns to `PreprodArtifact` - Add `InstallableAppErrorCode` enum (UNKNOWN, NO_QUOTA, SKIPPED) following the existing `ErrorCode` pattern on `PreprodArtifact` - Migration: `0027_add_distribution_state_fields` Uses an error-code model instead of a state field so that `installable_app_file_id` implicitly encodes success, avoiding ambiguous state combinations: - `file_id` set + no error → success - no `file_id` + error code set → skipped/failed - no `file_id` + no error → pending / not yet determined Split out from #109062 to land the schema change independently. EME-842
wedamija
pushed a commit
that referenced
this pull request
Feb 24, 2026
…842) (#109075) ## Summary - Add `installable_app_error_code` and `installable_app_error_message` columns to `PreprodArtifact` - Add `InstallableAppErrorCode` enum (UNKNOWN, NO_QUOTA, SKIPPED) following the existing `ErrorCode` pattern on `PreprodArtifact` - Migration: `0027_add_distribution_state_fields` Uses an error-code model instead of a state field so that `installable_app_file_id` implicitly encodes success, avoiding ambiguous state combinations: - `file_id` set + no error → success - no `file_id` + error code set → skipped/failed - no `file_id` + no error → pending / not yet determined Split out from #109062 to land the schema change independently. EME-842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installable_app_error_codeandinstallable_app_error_messagecolumns toPreprodArtifactInstallableAppErrorCodeenum (UNKNOWN, NO_QUOTA, SKIPPED) following the existingErrorCodepattern onPreprodArtifact0027_add_distribution_state_fieldsUses an error-code model instead of a state field so that
installable_app_file_idimplicitly encodes success, avoiding ambiguous state combinations:file_idset + no error → successfile_id+ error code set → skipped/failedfile_id+ no error → pending / not yet determinedSplit out from #109062 to land the schema change independently.
EME-842