fix(tests): Fix flaky test_impersonation_enforces_rate_limits_when_disabled timing#109095
Open
fix(tests): Fix flaky test_impersonation_enforces_rate_limits_when_disabled timing#109095
Conversation
…sabled timing Wrap the test in freeze_time to prevent the 1-second rate limit window from expiring between middleware calls, which caused non-deterministic rate limiting behavior. Fixes #109043
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
freeze_time("2000-01-01")to prevent the 1-second rate limit window from expiring between middleware callsTest plan
Fixes #109043