feat(seer): Add Explorer methods to SeerEntrypoint protocol#109231
Draft
Conversation
Add a second generic (ExplorerCachePayloadT) to SeerEntrypoint and SeerOperator, and define Explorer lifecycle methods on the protocol: on_trigger_explorer_error, on_trigger_explorer_success, create_explorer_cache_payload, and on_explorer_update. ISWF-2020
…ocol SlackEntrypoint and MockEntrypoint now implement the new Explorer methods with no-op stubs. Also fixes MockEntrypoint to use 2 type args. ISWF-2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExplorerCachePayloadT) toSeerEntrypointprotocol andSeerOperatoron_trigger_explorer_error,on_trigger_explorer_success,create_explorer_cache_payload,on_explorer_updateSlackEntrypointto use the two-generic signatureBuilds on #107785.
ISWF-2020