WIP: feat(metric alerts): Add tests for differences in workflow-engine-rule-serializers output#109242
Draft
WIP: feat(metric alerts): Add tests for differences in workflow-engine-rule-serializers output#109242
Conversation
github-actions
bot
added
the
Scope: Backend
ceorourke
reviewed
Feb 24, 2026
| ) | ||
| ) | ||
| if "original_alert_rule" in self.expand and alert_rule_ids: | ||
| snapshot_activities = AlertRuleActivity.objects.filter( |
Member
There was a problem hiding this comment.
Unfortunately we want to avoid using any of the old models so AlertRuleActivity can't be queried here. It was a long time ago but I think we decided to just not populate this data.
Comment on lines
+470
to
+473
| if snooze: | ||
| data["snooze"] = True | ||
| else: | ||
| data["snooze"] = False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to add tests to endpoints that use WorkflowEngineDetectorSerializer to compare to legacy behavior, reporting the diff.
It also includes some attempts to resolve these differences.