test: get eslintPluginScraps tests running, and fixed use-semantic-token's#109326
Merged
JoshuaKGoldberg merged 1 commit intomasterfrom Feb 26, 2026
Merged
test: get eslintPluginScraps tests running, and fixed use-semantic-token's#109326JoshuaKGoldberg merged 1 commit intomasterfrom
JoshuaKGoldberg merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
commented
Feb 25, 2026
Member
Author
There was a problem hiding this comment.
[Question] I removed invalid* object entries that didn't produce any lint rule reports. Was that correct? Should this change move them to valid, or...?
JonasBa
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #109310, changes the test extensions from
*.spec.mjsto*.spec.js. Themis unnecessary because Jest is configured to treat their syntax as ESM either way.static/eslint/eslintPluginScraps/src/rules/use-semantic-token.spec.jshad some failures in the helper-function-generated invalid cases:invalidPropertymessage ID instead ofinvalidPropertyWithSuggestion, and missingdata.suggestedCategoryFixes https://linear.app/getsentry/issue/ENG-6931/get-eslintpluginscraps-tests-running