ref(tempest): migrate configForm to AutoSaveField#109363
Merged
Merged
Conversation
Replaces the legacy JsonForm/Form system with AutoSaveField from @sentry/scraps/form. Adds a collocated test file covering label rendering, initial state, toggle API call, and undefined value handling.
Add ProjectsStore.onUpdateSuccess in the mutationOptions.onSuccess callback so that the global project store is updated after a successful PUT, matching the behaviour of the legacy Form component's onSubmitSuccess handler used across other project settings pages. Also update the spec to import ConfigForm via relative path (so the worktree module is resolved correctly in the shared Jest root) and add a test verifying the ProjectsStore.onUpdateSuccess call on success.
github-actions
Bot
added
the
Scope: Frontend
JonasBa
commented
Feb 25, 2026
TkDodo
approved these changes
Feb 26, 2026
github-actions
Bot
added
the
Scope: Backend
JonasBa
force-pushed
the
worktree-agent-adeb85b3
branch
from
cbea679 to
abc5643
Compare
JonasBa
removed
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
static/app/views/settings/project/tempest/configForm.tsxfrom the legacyForm/JsonFormsystem to the newAutoSaveFieldfrom@sentry/scraps/form.The legacy form used
saveOnBluron a<Form>wrapper with a<JsonForm>field config array. The new implementation usesAutoSaveFieldwith a Zod schema, amutationFncallingfetchMutation, and aFormSearchwrapper so the field is indexed by settings search.Changes:
Form/JsonFormwithAutoSaveField+FieldGroup+FormSearchhelp→hintTextonfield.Layout.RowonSuccess: response => ProjectsStore.onUpdateSuccess(response)to keep the global project store fresh after save (matching the pattern used in other project settings forms likeprojectReplays.tsx)FormSearchwrapper with route/settings/:orgId/projects/:projectId/playstation/so the "Attach Screenshots" toggle is discoverable via settings searchextract-form-fieldsto register the field ingeneratedFieldRegistry.tsconfigForm.spec.tsxwith 6 tests covering label/hint rendering, initial switch state, API call data shape,ProjectsStoreupdate on success, and graceful handling ofundefinedinitial value