ref(replays): migrate projectReplays settings to AutoSaveField#109364
Merged
ref(replays): migrate projectReplays settings to AutoSaveField#109364
Conversation
Replaces the legacy Form/JsonForm pattern with AutoSaveField from
@sentry/scraps/form. Both boolean fields share a single mutationFn
that wraps the data in {options: data} as required by the project
settings endpoint.
Restore the ProjectsStore.onUpdateSuccess(response) call in the mutationOptions onSuccess handler, which was lost in the initial migration. The old Form had onSubmitSuccess that updated the project store; this preserves that behavior using typed fetchMutation<Project>.
Wrap the component return in <FormSearch route="/settings/:orgId/projects/:projectId/replays/"> so both AutoSaveFields are discoverable by settings search. Re-run extract-form-fields to register the two replay fields in generatedFieldRegistry.ts.
github-actions
bot
added
the
Scope: Frontend
TkDodo
approved these changes
Feb 26, 2026
Co-authored-by: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
JonasBa
force-pushed
the
worktree-agent-af4252fb
branch
from
f036422 to
8a551bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
static/app/views/settings/project/projectReplays.tsxfrom the legacyForm/JsonFormsystem to the newAutoSaveField-based approach from@sentry/scraps/form.The page had two boolean fields (
sentry:replay_rage_click_issuesandsentry:replay_hydration_error_issues) wrapped in a<Form saveOnBlur>+<JsonForm>. These are straightforward auto-save toggles with no confirmation dialogs or custom error handling, making them a clean migration target.What changed:
Form/JsonFormwith twoAutoSaveFieldcomponents inside aFieldGroupgetData: data => ({options: data})is handled inmutationFnviadata: {options: data}helptext migrated tohintTextonfield.Layout.Row; the JSX help text for the hydration field is passed astct(...)directly tohintTextonSubmitSuccess→onSuccessinmutationOptions, callingProjectsStore.onUpdateSuccess(response)with a typedfetchMutation<Project>to keep the project store consistent<FormSearch route="/settings/:orgId/projects/:projectId/replays/">so both fields are discoverable via settings searchpnpm run extract-form-fieldsto register both fields ingeneratedFieldRegistry.tsunderformId: 'project-replays'projectReplays.spec.tsx: useProjectFixturewith explicitoptions, addwaitForfor async assertions, add a second test for the hydration error toggle, add a render test for both labels