feat(preprod): Add snapshot comparison Celery task#109382
Open
NicoHinderling wants to merge 7 commits intocreate-compare-task-v1-part2from
Open
feat(preprod): Add snapshot comparison Celery task#109382NicoHinderling wants to merge 7 commits intocreate-compare-task-v1-part2from
NicoHinderling wants to merge 7 commits intocreate-compare-task-v1-part2from
Conversation
f4a0ef2 to
925d6b9
Compare
d3c1b90 to
85baf2d
Compare
This was referenced Feb 25, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
925d6b9 to
bbf23d9
Compare
85baf2d to
cf39e6f
Compare
5bc8093 to
e05fbd9
Compare
bbf23d9 to
8c12f49
Compare
Closed
8c12f49 to
bbba6eb
Compare
e05fbd9 to
d5d5560
Compare
bbba6eb to
99c5a0b
Compare
d5d5560 to
1f0aee4
Compare
1f0aee4 to
700c27e
Compare
99c5a0b to
6e0d8b2
Compare
fb22dd0 to
a223ea2
Compare
c0646ba to
e8f1295
Compare
a223ea2 to
51a1671
Compare
e8f1295 to
d1bdbb5
Compare
51a1671 to
8075590
Compare
8075590 to
e13638e
Compare
8096c1f to
f5bbcd7
Compare
e13638e to
7c7e142
Compare
Add compare_snapshots task that loads manifests from objectstore, diffs matched images in pixel-budget batches via OdiffServer, uploads diff masks, and writes comparison results with state machine guards.
Corrupt manifest data from object store will never succeed on retry. Catch orjson.JSONDecodeError explicitly to mark the comparison as FAILED and return, avoiding 3 wasted retries.
7c7e142 to
cddf7ff
Compare
f5bbcd7 to
561b410
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
compare_snapshotsinstrumented task that loads manifests from objectstore, diffs matched images in pixel-budget batches, uploads diff masks, and writes comparison resultsserver.pyStack: 3/3 — depends on #109381