Get started calling GitLab#109468
Draft
jacquev6 wants to merge 5 commits intojacquev6/scm-platform-clientfrom
Draft
Get started calling GitLab#109468jacquev6 wants to merge 5 commits intojacquev6/scm-platform-clientfrom
jacquev6 wants to merge 5 commits intojacquev6/scm-platform-clientfrom
Conversation
github-actions
bot
added
the
Scope: Backend
Collaborator
Author
|
@cmanallen we need to talk about 7dca827. I pushed it here because I'm not sure about my fix, but the actual fix belongs in #107360. I'll bring it up in stand-up tonight. |
cmanallen
reviewed
Feb 27, 2026
| state="open", | ||
| base=PullRequestBranch( | ||
| ref=raw["target_branch"], | ||
| sha="", # @todo Fetch sha for target branch? But then risk rate-limits and inconsistencies (race conditions)? |
Member
There was a problem hiding this comment.
We'll have to make it nullable and make users look up the SHA using a different SCM function.
| sha=raw["sha"], | ||
| ), | ||
| merged=raw["merged_at"] is not None, | ||
| url="", # @todo Remove attribute? |
| email=raw["author_email"], | ||
| date=datetime.datetime.fromisoformat(raw["created_at"]), | ||
| ), | ||
| files=[], # @todo |
Member
There was a problem hiding this comment.
Probably should be made nullable and then have the null value signal that files need to be fetched on a subsequent request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to implement #108968 with a more "vertical" approach: instead of implementing a wide layer without being able to really test it, I'm going to implement each SCM platform method end-to-end: I should be able to test each one from the SCM RPC client down to GitLab and back.
As a result, this should not be merged as-is: it's based on #108123 which should not be merged. We'll need to rebase these changes onto #107360. And to make my life easier, I'm also pushing changes that don't belong in Sentry's code base, in commits with messages starting with "TMP".
I'm opening this draft so that @cmanallen can follow my progress.