Skip to content

ref(scraps): unify FormWrapper and AppForm#109474

Merged
TkDodo merged 6 commits into
masterfrom
tkdodo/ref/appform-api
Feb 26, 2026
Merged

ref(scraps): unify FormWrapper and AppForm#109474
TkDodo merged 6 commits into
masterfrom
tkdodo/ref/appform-api

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Feb 26, 2026

This is a breaking change in the form API, so once we merge this, all open PRs need to update.

before:

<form.AppForm>
  <form.FormWrapper>
    ...
  </form.FormWrapper>
</form.AppForm>

after:

<form.AppForm form={form}>
  ...
</form.AppForm>

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 26, 2026
@TkDodo TkDodo marked this pull request as ready for review February 26, 2026 10:00
@TkDodo TkDodo requested a review from a team as a code owner February 26, 2026 10:00
Copy link
Copy Markdown
Member

@JonasBa JonasBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great little quality of life consolidation 🙏🏼

# Conflicts:
#	static/app/components/core/form/form.stories.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.

Comment thread static/app/components/core/form/scrapsForm.tsx
@TkDodo TkDodo merged commit b309585 into master Feb 26, 2026
58 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/appform-api branch February 26, 2026 13:16
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants