Skip to content

feat(seer): Iterate on the instructions at the top of seer settings pages#109586

Merged
ryan953 merged 3 commits intomasterfrom
ryan953/seer-settings-wrapper-copy
Feb 28, 2026
Merged

feat(seer): Iterate on the instructions at the top of seer settings pages#109586
ryan953 merged 3 commits intomasterfrom
ryan953/seer-settings-wrapper-copy

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Feb 27, 2026

Before
All pages had the same copy at the top, and the tab labels were messy

Tab Img
All tabs the same SCR-20260227-jhlr

After
more product centric, and trying to explain how things work

Tab Img
Settings Screenshot 2026-02-27 at 10 07 20 AM
Autofix Screenshot 2026-02-27 at 10 07 23 AM
Code Review Screenshot 2026-02-27 at 10 09 35 AM
Autofix for $project SCR-20260227-nxrz
Code Review for $repo SCR-20260227-nxls

Also i snuck in a copy change to align the copy for Create Pull Request checkbox

Seer Agent Cursor Agent
Screenshot 2026-02-27 at 10 12 57 AM Screenshot 2026-02-27 at 10 13 01 AM

@ryan953 ryan953 requested a review from a team as a code owner February 27, 2026 18:09
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 27, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@ryan953 ryan953 requested a review from ivy-sentry February 27, 2026 18:15
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more clear imo

@ryan953 ryan953 force-pushed the ryan953/seer-settings-wrapper-copy branch from 80f64b8 to 6e8bec5 Compare February 27, 2026 23:46
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an extract from static/gsApp/views/seerAutomation/components/seerSettingsPageWrapper.tsx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bulk of this file is whitespace changes.

@ryan953 ryan953 merged commit c0d1d3f into master Feb 28, 2026
60 checks passed
@ryan953 ryan953 deleted the ryan953/seer-settings-wrapper-copy branch February 28, 2026 00:24
jan-auer added a commit that referenced this pull request Mar 2, 2026
…ept-encoding

* origin/master: (63 commits)
  fix(api): Add missing cursor query parameter to paginated endpoint OpenAPI schemas (#109642)
  docs(sentry-apps): Add sentryAppId to sentry-app-installations API schema (#109628)
  feat(occurrences on eap): Implement double reads from EAP in organization events trace API endpoint (#109391)
  feat(occurrences on eap): Implement double reads from EAP for reprocessing2 flow (#109345)
  feat(ci): report backend test fails (#109543)
  feat(seer): Add signed viewer context header to Seer API requests (#109626)
  devenv: cleanup devenv-managed uv (#109617)
  feat(seer): Iterate on the instructions at the top of seer settings pages (#109586)
  ref(seer): Add typed wrappers for remaining Seer API callsites (#109607)
  feat(preprod): Make snapshots endpoint org scoped (#109575)
  chore: capture exception (#109620)
  fix(formatting): run ruff format (#109618)
  feat(preprod): Create admin gated recompare snapshots endpoint (#109546)
  feat(cells): expand locality/cell distinction (#109538)
  feat(cells): add db migration for synapse (#109615)
  feat(preprod): Add public install-details endpoint and shared utilities (#109583)
  fix(tests): Fix flaky test_cross_trace_query_with_spans_and_logs (#109572)
  fix(grouping): Resolve mypy possibly-undefined errors in grouphash caching (#109602)
  fix(dashboards): Default axisRange to auto for existing widgets in builder (#109598)
  fix(billing): Fix category display names in pending changes (#109612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants