Skip to content

chore(sdk-crash-detection): Add more ignores to Java config #109648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 2 commits into from
Mar 2, 2026
Merged

chore(sdk-crash-detection): Add more ignores to Java config #109648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32926ab
chore(sdk-crash-detection): Add more ignores to Java config
romtsn Mar 2, 2026
99180b2
Merge branch 'master' into rz/chore/sdk-crashes-java-new-ignores
romtsn Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/sentry/utils/sdk_crashes/sdk_crash_detection_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,27 @@ def build_sdk_crash_detection_configs() -> Sequence[SDKCrashDetectionConfig]:
module_pattern="io.sentry.graphql.SentryGraphqlInstrumentation",
function_pattern="instrumentExecutionResultComplete",
),
# WindowCallbackAdapter just forwards the calls to the next callback in the chain.
# It does not cause crashes/ANRs itself.
FunctionAndModulePattern(
module_pattern="io.sentry.android.core.internal.gestures.WindowCallbackAdapter",
function_pattern="*",
),
# All functions that we delegate to are inside lambdas, so we ignore them.
FunctionAndModulePattern(
module_pattern="io.sentry.android.sqlite.SentrySupportSQLiteStatement$*",
function_pattern="invoke",
),
# Our wrapper class does not override beginTransaction, so we ignore it.
FunctionAndModulePattern(
module_pattern="io.sentry.android.sqlite.SentrySupportSQLiteDatabase",
function_pattern="beginTransaction*",
),
# Our wrapper class does not override any move* methods, so we ignore it.
FunctionAndModulePattern(
module_pattern="io.sentry.android.sqlite.SentryCrossProcessCursor",
function_pattern="move*",
),
},
)
configs.append(java_config)
Expand Down
36 changes: 36 additions & 0 deletions tests/sentry/utils/sdk_crashes/test_sdk_crash_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,42 @@ def test_build_sdk_crash_detection_configs(
True,
"Should report a crash when function pattern is wildcard but module doesn't match",
),
(
"invoke_match_module_prefix_with_suffix",
[
FunctionAndModulePattern(
module_pattern="io.sentry.android.sqlite.SentrySupportSQLiteStatement$*",
function_pattern="invoke",
)
],
[
{
"function": "invoke",
"module": "io.sentry.android.sqlite.SentrySupportSQLiteStatement$bindLong$1",
"package": "MyApp",
}
],
False,
"Should not report a crash when module matches SentrySupportSQLiteStatement$* and function is invoke",
),
(
"begin_transaction_match_database_wrapper",
[
FunctionAndModulePattern(
module_pattern="io.sentry.android.sqlite.SentrySupportSQLiteDatabase",
function_pattern="beginTransaction*",
)
],
[
{
"function": "beginTransactionNonExclusive",
"module": "io.sentry.android.sqlite.SentrySupportSQLiteDatabase",
"package": "MyApp",
}
],
False,
"Should not report a crash when beginTransaction* is called on SentrySupportSQLiteDatabase",
),
],
)
def test_sdk_crash_ignore_matchers(
Expand Down
Loading