ref(attachments): Clean up objectstore rollout options#109674
Merged
ref(attachments): Clean up objectstore rollout options#109674
Conversation
github-actions
bot
added
the
Scope: Backend
jan-auer
force-pushed
the
ref/remove-objectstore-enable-for
branch
from
454aebb to
e4cda67
Compare
lcian
approved these changes
Mar 3, 2026
jan-auer
force-pushed
the
ref/remove-objectstore-enable-for
branch
from
e4cda67 to
812aca6
Compare
jan-auer
force-pushed
the
ref/remove-objectstore-enable-for
branch
from
2d80d0f to
2a2b1f2
Compare
…flag - Remove `objectstore.double_write.attachments` option and associated double-write code path from `EventAttachment.putfile` - Remove `objectstore.enable_for.cached_attachments` option from the attachment cache layer; temporary attachments always use the cache now - Re-introduce `objectstore.enable_for.attachments` (default: 0.0) to gate whether `EventAttachment.putfile` writes to objectstore (V2) or GCS/local storage (V1). Default is False in production. - Set the option to 1.0 in test configuration so tests always exercise the objectstore path - In `reprocessing2._maybe_copy_attachment_into_cache`: V2 attachments are handled regardless of the flag. When the flag is enabled, V1 attachments are migrated into objectstore (and the V1 object deleted). When the flag is disabled, V1 attachments are copied into the chunk-based attachment cache as before.
jan-auer
force-pushed
the
ref/remove-objectstore-enable-for
branch
from
2a2b1f2 to
e90a813
Compare
jan-auer
changed the title
Add objectstore to the default dev mode so it starts automatically, removing the need for a separate objectstore mode. Also add it to the taskbroker and symbolicator modes.
jjbayer
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cached-attachment objectstore rollout options now that migration is complete, keeping only the single
enable_for.attachmentsflag that gates whether new attachments land in objectstore or legacy storage. Note that ingestion via Relay is controlled separately.Reprocessing is updated to always handle attachments that are already in objectstore (regardless of the flag), while still migrating V1 attachments into objectstore during reprocessing when the flag is on.
Objectstore is also added to the default devservices mode so it starts alongside the rest of the stack without needing a separate mode.
Refs FS-281