Skip to content

ref(grouping): Add git SHA parameterization#109753

Merged
lobsterkatie merged 2 commits intomasterfrom
kmclb-add-git-sha-parameterization
Mar 4, 2026
Merged

ref(grouping): Add git SHA parameterization#109753
lobsterkatie merged 2 commits intomasterfrom
kmclb-add-git-sha-parameterization

Conversation

@lobsterkatie
Copy link
Member

It is standard git practice to abbreviate commit SHAs to 7 digits where there's no ambiguity. However, for message parameterization our current hex matching only applies to strings 8 characters and up. This therefore adds a new, separate pattern to our collection of parameterizer regexes, specifically to match git SHAs. It's similar to our hex regex, but stricter, in that the string must be exactly 7 characters, must include both a letter and a number (this will miss a few, but both words and ints are more common, so we let them win), and must only use lowercase letters, as git always does.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 3, 2026
@lobsterkatie lobsterkatie marked this pull request as ready for review March 4, 2026 17:52
@lobsterkatie lobsterkatie requested a review from a team as a code owner March 4, 2026 17:52
Copy link
Member

@shashjar shashjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@lobsterkatie lobsterkatie merged commit a3224b6 into master Mar 4, 2026
77 of 83 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-add-git-sha-parameterization branch March 4, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants