ref(grouping): Add git SHA parameterization#109753
Merged
lobsterkatie merged 2 commits intomasterfrom Mar 4, 2026
Merged
Conversation
wedamija
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is standard git practice to abbreviate commit SHAs to 7 digits where there's no ambiguity. However, for message parameterization our current hex matching only applies to strings 8 characters and up. This therefore adds a new, separate pattern to our collection of parameterizer regexes, specifically to match git SHAs. It's similar to our hex regex, but stricter, in that the string must be exactly 7 characters, must include both a letter and a number (this will miss a few, but both words and ints are more common, so we let them win), and must only use lowercase letters, as git always does.