ref(spans): Remove unused end_timestamp from Span NamedTuple#109788
Merged
ref(spans): Remove unused end_timestamp from Span NamedTuple#109788
Conversation
The end_timestamp field on the buffer's Span NamedTuple was dead code. _prepare_payloads stored timestamps as dict values, but the only caller used p.sadd(set_key, *set_members.keys()), discarding the values entirely. Simplify _prepare_payloads to return a set instead of a dict. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
lvthanh03
reviewed
Mar 3, 2026
Member
There was a problem hiding this comment.
can we remove this assertion as well? also, I'm not sure if start_timestamp is used.
untitaker
commented
Mar 3, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
untitaker
force-pushed
the
ref/remove-span-end-timestamp
branch
from
17b9eab to
6ce3add
Compare
The start_timestamp and end_timestamp assertions in validate_span_event only protected downstream systems, not the span buffer itself. Downstream consumers should validate their own inputs. Co-Authored-By: Claude <noreply@anthropic.com>
lvthanh03
reviewed
Mar 3, 2026
Member
lvthanh03
left a comment
lvthanh03
left a comment
There was a problem hiding this comment.
The schema still requires start_timestamp and end_timestamp, the spans we produce to buffered-segments still have these attributes right?
Member
Author
|
@lvthanh03 yeah but i would argue the span buffer should not validate this constraint. segments consumer should protect itself |
lvthanh03
approved these changes
Mar 3, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
evanh
approved these changes
Mar 4, 2026
Address review feedback: fix set[str | bytes, float] -> set[str | bytes] and update docstring to reflect the method now returns a set, not a dict.
…-timestamp # Conflicts: # src/sentry/spans/buffer.py # tests/sentry/spans/consumers/process/test_consumer.py
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
New tests added on master also used end_timestamp in Span() constructors.
Contributor
Backend Test FailuresFailures on
|
This test validated end_timestamp type checking which we've removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a leftover from the time we used end_timestamp to trim segments intelligently. Now we moved to unsorted sets, and it's no longer needd.
Co-Authored-By: Claude noreply@anthropic.com