fix(alerts): Trace metrics shouldn't error on query validator#109824
Merged
fix(alerts): Trace metrics shouldn't error on query validator#109824
Conversation
- Fixes SENTRY-5KRT - The issue was that with both the tracemetric flags and custom-metrics enabled the check to see if an MRI was being used outside of PerfMetrics would fail since `get_column_from_aggregate` doesn't account for the query dataset. Updated the check so that when it hits columns its unaware of it just assumes the column is not an MRI
github-actions
bot
added
the
Scope: Backend
k-fish
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_column_from_aggregatedoesn't account for the query dataset. Updated the check so that when it hits columns its unaware of it just assumes the column is not an MRI