Skip to content

fix(tests): Fix pre-prod eap integration tests #109852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wedamija merged 2 commits into from
Mar 4, 2026
Merged

fix(tests): Fix pre-prod eap integration tests #109852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
813ac44
fix(tests): Fix pre-prod eap integration tests
wedamija Mar 4, 2026
84cb718
fix(tests): Use synchronous Snuba insertion in preprod EAP integratio…
wedamija Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added tests/snuba/preprod/__init__.py
View file
Open in desktop
Empty file.
Empty file added tests/snuba/preprod/eap/__init__.py
View file
Open in desktop
Empty file.
104 changes: 47 additions & 57 deletions tests/snuba/preprod/eap/test_preprod_eap_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import time
from datetime import datetime, timedelta
from datetime import timezone as dt_timezone

Expand All @@ -13,10 +12,12 @@
PreprodArtifactSizeMetrics,
PreprodBuildConfiguration,
)
from sentry.testutils.cases import SnubaTestCase
from sentry.testutils.cases import SnubaTestCase, TestCase

PREPROD_PRODUCER_MOCK_PATH = "sentry.preprod.eap.write._eap_producer.produce"

class PreprodEAPIntegrationTest(SnubaTestCase):

class PreprodEAPIntegrationTest(TestCase, SnubaTestCase):
def test_write_and_read_size_metric_round_trip(self):
commit_comparison = CommitComparison.objects.create(
organization_id=self.organization.id,
Expand Down Expand Up @@ -58,41 +59,35 @@ def test_write_and_read_size_metric_round_trip(self):
analysis_file_id=123,
)

produce_preprod_size_metric_to_eap(
self.produce_and_store_eap_items(
PREPROD_PRODUCER_MOCK_PATH,
produce_preprod_size_metric_to_eap,
size_metric=size_metric,
organization=self.organization,
organization_id=self.organization.id,
project_id=self.project.id,
)

max_attempts = 20
found = False

for attempt in range(max_attempts):
time.sleep(0.5)

app_filter = TraceItemFilter(
comparison_filter=ComparisonFilter(
key=AttributeKey(name="app_id", type=AttributeKey.Type.TYPE_STRING),
op=ComparisonFilter.OP_EQUALS,
value=AttributeValue(val_str="com.example.integrationtest"),
)
)

response = query_preprod_size_metrics(
organization_id=self.organization.id,
project_ids=[self.project.id],
start=datetime.now(dt_timezone.utc) - timedelta(hours=1),
end=datetime.now(dt_timezone.utc) + timedelta(hours=1),
referrer="test.preprod.integration",
filter=app_filter,
app_filter = TraceItemFilter(
comparison_filter=ComparisonFilter(
key=AttributeKey(name="app_id", type=AttributeKey.Type.TYPE_STRING),
op=ComparisonFilter.OP_EQUALS,
value=AttributeValue(val_str="com.example.integrationtest"),
)
)

if response.column_values:
found = True
break
response = query_preprod_size_metrics(
organization_id=self.organization.id,
project_ids=[self.project.id],
start=datetime.now(dt_timezone.utc) - timedelta(hours=1),
end=datetime.now(dt_timezone.utc) + timedelta(hours=1),
referrer="test.preprod.integration",
filter=app_filter,
)

assert found, f"Data not found in Snuba after {max_attempts} attempts"
assert response.column_values and response.column_values[0].results, (
"Data not found in Snuba"
)

columns = {cv.attribute_name: idx for idx, cv in enumerate(response.column_values)}

Expand Down Expand Up @@ -154,49 +149,44 @@ def test_write_multiple_size_metrics_same_artifact(self):
max_install_size=1000,
)

produce_preprod_size_metric_to_eap(
self.produce_and_store_eap_items(
PREPROD_PRODUCER_MOCK_PATH,
produce_preprod_size_metric_to_eap,
size_metric=size_metric_main,
organization=self.organization,
organization_id=self.organization.id,
project_id=self.project.id,
)

produce_preprod_size_metric_to_eap(
self.produce_and_store_eap_items(
PREPROD_PRODUCER_MOCK_PATH,
produce_preprod_size_metric_to_eap,
size_metric=size_metric_watch,
organization=self.organization,
organization_id=self.organization.id,
project_id=self.project.id,
)

max_attempts = 20
found_count = 0

for attempt in range(max_attempts):
time.sleep(0.5)

app_filter = TraceItemFilter(
comparison_filter=ComparisonFilter(
key=AttributeKey(name="app_id", type=AttributeKey.Type.TYPE_STRING),
op=ComparisonFilter.OP_EQUALS,
value=AttributeValue(val_str="com.example.multitest"),
)
)

response = query_preprod_size_metrics(
organization_id=self.organization.id,
project_ids=[self.project.id],
start=datetime.now(dt_timezone.utc) - timedelta(hours=1),
end=datetime.now(dt_timezone.utc) + timedelta(hours=1),
referrer="test.preprod.integration",
filter=app_filter,
app_filter = TraceItemFilter(
comparison_filter=ComparisonFilter(
key=AttributeKey(name="app_id", type=AttributeKey.Type.TYPE_STRING),
op=ComparisonFilter.OP_EQUALS,
value=AttributeValue(val_str="com.example.multitest"),
)
)

if response.column_values:
found_count = len(response.column_values[0].results)
if found_count >= 2:
break
response = query_preprod_size_metrics(
organization_id=self.organization.id,
project_ids=[self.project.id],
start=datetime.now(dt_timezone.utc) - timedelta(hours=1),
end=datetime.now(dt_timezone.utc) + timedelta(hours=1),
referrer="test.preprod.integration",
filter=app_filter,
)

assert found_count == 2, f"Expected 2 records, found {found_count}"
assert response.column_values and len(response.column_values[0].results) == 2, (
f"Expected 2 records, found {len(response.column_values[0].results) if response.column_values else 0}"
)

columns = {cv.attribute_name: idx for idx, cv in enumerate(response.column_values)}
num_rows = len(response.column_values[0].results)
Expand Down
Loading