fix(auth): Fix for impersonated sessions#109903
Merged
michelletran-sentry merged 1 commit intomasterfrom Mar 5, 2026
Merged
Conversation
Impersonated superuser sessions bypass the data secrecy check because is_active_superuser() returns False during impersonation, skipping the get_superuser_scopes() path that enforces data secrecy. Add a guard in both from_request_org_and_scopes() and from_request() to check for request.actual_user and raise DataSecrecyError when the target org has data secrecy enabled. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
geoffg-sentry
approved these changes
Mar 5, 2026
Contributor
geoffg-sentry
left a comment
geoffg-sentry
left a comment
There was a problem hiding this comment.
well that's easier than expected
JonasBa
pushed a commit
that referenced
this pull request
Mar 5, 2026
Co-authored-by: Claude <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.