feat: Add branch to use taskbroker-client#110001
Merged
Conversation
Add branches that let us opt-in to using taskbroker-client in deployments via environment variables. Refs STREAM-610
Fix type errors in sentry.taskworker, there are likely more.
use some cheatcodes to get around mypy
There are instanceof checks in the scheduler that we need to work around.
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
evanh
approved these changes
Mar 9, 2026
| runner = ScheduleRunner(app, run_storage) | ||
| for key, schedule_data in settings.TASKWORKER_SCHEDULES.items(): | ||
| runner.add(key, schedule_data) | ||
| with managed_bgtasks(role="taskworker-scheduler"): |
Member
There was a problem hiding this comment.
Would it be worth it to move these two different code paths into separate files and import them here?
Member
Author
There was a problem hiding this comment.
I think that would be a good idea if this was going to stick around for a long time. I'm hoping that these branches only exist for a week or so to complete the rollout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add branches that let us opt-in to using taskbroker-client in deployments via environment variables.
Refs STREAM-610