Skip to content

chore(tests): replace store_occurrences with store_eap_items#110140

Merged
wedamija merged 1 commit into
masterfrom
danf/consolidate-store-occurrences
Mar 6, 2026
Merged

chore(tests): replace store_occurrences with store_eap_items#110140
wedamija merged 1 commit into
masterfrom
danf/consolidate-store-occurrences

Conversation

@wedamija
Copy link
Copy Markdown
Member

@wedamija wedamija commented Mar 6, 2026

store_occurrences is functionally identical to store_eap_items — both serialize protobuf TraceItems and POST them to the EAP items insert endpoint. The only difference was the multipart file key prefix (e.g. "occurrence_0" vs "eap_items_0"), which Snuba ignores.

Consolidating to a single helper reduces duplication in test utilities.

store_occurrences is functionally identical to store_eap_items —
both serialize protobuf TraceItems and POST them to the EAP items
insert endpoint. The only difference was the multipart file key prefix
(e.g. "occurrence_0" vs "eap_items_0"), which Snuba ignores.

Consolidating to a single helper reduces duplication in test utilities.
@wedamija wedamija requested a review from a team March 6, 2026 19:21
@wedamija wedamija requested review from a team as code owners March 6, 2026 19:21
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2026
@wedamija wedamija merged commit c86eb6a into master Mar 6, 2026
78 checks passed
@wedamija wedamija deleted the danf/consolidate-store-occurrences branch March 6, 2026 20:05
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants