Skip to content

chore: Update CODEOWNERS to use coding-workflows sub-teams#110149

Merged
vaind merged 3 commits into
masterfrom
ivan/codeowners-coding-workflows-subteams
Mar 10, 2026
Merged

chore: Update CODEOWNERS to use coding-workflows sub-teams#110149
vaind merged 3 commits into
masterfrom
ivan/codeowners-coding-workflows-subteams

Conversation

@vaind
Copy link
Copy Markdown
Contributor

@vaind vaind commented Mar 6, 2026

Summary

  • Replace @getsentry/coding-workflows with @getsentry/coding-workflows-sentry-backend and @getsentry/coding-workflows-sentry-frontend sub-teams in CODEOWNERS
  • Backend paths (/src/sentry/prevent/, /src/sentry/seer/code_review/, etc.) → coding-workflows-sentry-backend
  • Frontend paths (/static/app/components/prevent/, /static/app/views/prevent/, etc.) → coding-workflows-sentry-frontend

Follows getsentry/security-as-code#2538 which renames and nests these teams under the coding-workflows parent.

Test plan

  • Verified no other CODEOWNERS references to the old parent team remain

Use the new `coding-workflows-sentry-backend` and
`coding-workflows-sentry-frontend` sub-teams instead of the parent
`coding-workflows` team for more targeted code review assignments.

Follows getsentry/security-as-code#2538 which renames and nests these
teams under the coding-workflows parent.
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Backend Test Failures

Failures on efcb35e in this run:

tests/sentry/api/test_api_owners.py::APIOwnersTestCase::test_api_owner_is_a_valid_code_ownerlog
tests/sentry/api/test_api_owners.py:22: in test_api_owner_is_a_valid_code_owner
    assert owner.value in self.teams
E   AssertionError: assert 'coding-workflows' in {'alerts-create-issues', 'alerts-notifications', 'codecov', 'coding-workflows-sentry-backend', 'crons', 'dashboards', ...}
E    +  where 'coding-workflows' = <ApiOwner.CODING_WORKFLOWS: 'coding-workflows'>.value
E    +  and   {'alerts-create-issues', 'alerts-notifications', 'codecov', 'coding-workflows-sentry-backend', 'crons', 'dashboards', ...} = <tests.sentry.api.test_api_owners.APIOwnersTestCase testMethod=test_api_owner_is_a_valid_code_owner>.teams

@vaind vaind requested review from a team March 6, 2026 20:45
@vaind vaind marked this pull request as ready for review March 6, 2026 20:45
@vaind vaind requested a review from a team as a code owner March 6, 2026 20:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Backend Test Failures

Failures on 5f50d43 in this run:

tests/sentry/api/test_api_owners.py::APIOwnersTestCase::test_api_owner_is_a_valid_code_ownerlog
tests/sentry/api/test_api_owners.py:22: in test_api_owner_is_a_valid_code_owner
    assert owner.value in self.teams
E   AssertionError: assert 'coding-workflows' in {'alerts-create-issues', 'alerts-notifications', 'codecov', 'coding-workflows-sentry-backend', 'crons', 'dashboards', ...}
E    +  where 'coding-workflows' = <ApiOwner.CODING_WORKFLOWS: 'coding-workflows'>.value
E    +  and   {'alerts-create-issues', 'alerts-notifications', 'codecov', 'coding-workflows-sentry-backend', 'crons', 'dashboards', ...} = <tests.sentry.api.test_api_owners.APIOwnersTestCase testMethod=test_api_owner_is_a_valid_code_owner>.teams

The team was renamed from `coding-workflows` to
`coding-workflows-sentry-backend` in CODEOWNERS but the ApiOwner enum
was not updated, causing test_api_owner_is_a_valid_code_owner to fail.
@vaind vaind merged commit 6bd3d0d into master Mar 10, 2026
55 checks passed
@vaind vaind deleted the ivan/codeowners-coding-workflows-subteams branch March 10, 2026 00:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants