Skip to content

ref: remove unreachable form#110228

Merged
TkDodo merged 1 commit into
masterfrom
tkdodo/ref/remove-unreachable-form
Mar 10, 2026
Merged

ref: remove unreachable form#110228
TkDodo merged 1 commit into
masterfrom
tkdodo/ref/remove-unreachable-form

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Mar 9, 2026

the settings tab was added here in 2021:

and it was then removed from tabs and made inaccessible in 2023 here:

but since it wasn’t from the TABS type, the switch statement didn’t type error and still continued to render it.

part of DE-948

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 9, 2026
@TkDodo TkDodo marked this pull request as ready for review March 9, 2026 19:15
@TkDodo TkDodo requested a review from a team as a code owner March 9, 2026 19:15
@TkDodo TkDodo requested a review from a team March 9, 2026 19:15
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Mar 9, 2026

@TkDodo TkDodo merged commit f32d321 into master Mar 10, 2026
63 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/remove-unreachable-form branch March 10, 2026 07:57
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants