Skip to content

tests: Skip test_basic_resolving#110309

Merged
armenzg merged 2 commits into
masterfrom
cursor/sentry-profiles-test-path-ef5d
Mar 10, 2026
Merged

tests: Skip test_basic_resolving#110309
armenzg merged 2 commits into
masterfrom
cursor/sentry-profiles-test-path-ef5d

Conversation

@armenzg
Copy link
Copy Markdown
Member

@armenzg armenzg commented Mar 10, 2026

A couple of the recent symbolicator changes may have caused this regression:
https://github.com/getsentry/symbolicator/commits/master/

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@armenzg armenzg requested a review from a team as a code owner March 10, 2026 16:26
@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented Mar 10, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@armenzg armenzg self-assigned this Mar 10, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Test skipped with temporary marker in production code
    • Removed the accidentally committed @pytest.mark.skip decorator with vague reason to restore test coverage for profile deobfuscation via symbolicator.

Create PR

Or push these changes by commenting:

@cursor push f55f6f8768
Preview (f55f6f8768)
diff --git a/tests/sentry/profiles/test_task.py b/tests/sentry/profiles/test_task.py
--- a/tests/sentry/profiles/test_task.py
+++ b/tests/sentry/profiles/test_task.py
@@ -587,7 +587,6 @@
         assert response.status_code == 201, response.content
         assert len(response.json()) == 1
 
-    @pytest.mark.skip(reason="Temporarily skipped")
     @requires_symbolicator
     @pytest.mark.symbolicator
     def test_basic_resolving(self) -> None:

Comment thread tests/sentry/profiles/test_task.py Outdated
@armenzg armenzg changed the title Sentry profiles test path tests: Skip test_basic_resolving Mar 10, 2026
@armenzg armenzg enabled auto-merge (squash) March 10, 2026 16:27
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Mar 10, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on 8a6b399 in this run:

tests/sentry/profiles/test_task.py::DeobfuscationViaSymbolicator::test_inline_resolvinglog
tests/sentry/profiles/test_task.py:684: in test_inline_resolving
    assert android_profile["profile"]["methods"] == [
E   AssertionError: assert [{'class_name...andler', ...}] == [{'class_name...andler', ...}]
E     
E     At index 0 diff: {'class_name': 'io.sentry.sample.-$$Lambda$r3Avcbztes2hicEObh02jjhQqd4', 'name': 'onClick', 'signature': '()', 'source_file': '-.java', 'source_line': 2, 'data': {'deobfuscation_status': 'deobfuscated'}} != {'class_name': 'io.sentry.sample.-$$Lambda$r3Avcbztes2hicEObh02jjhQqd4', 'data': {'deobfuscation_status': 'deobfuscated'}, 'name': 'onClick', 'signature': '()', 'source_file': None, 'source_line': 2}
E     
E     Full diff:
E       [
E           {
E               'class_name': 'io.sentry.sample.-$$Lambda$r3Avcbztes2hicEObh02jjhQqd4',
E               'data': {
E                   'deobfuscation_status': 'deobfuscated',
E               },
E               'name': 'onClick',
E               'signature': '()',
E     -         'source_file': None,
E     ?                        ^^^^
E     +         'source_file': '-.java',
E     ?                        ^^^^^^^^
E               'source_line': 2,
E           },
E           {
E               'class_name': 'io.sentry.sample.MainActivity',
E               'data': {
E                   'deobfuscation_status': 'deobfuscated',
E               },
E               'inline_frames': [
E                   {
E                       'class_name': 'io.sentry.sample.MainActivity',
E                       'data': {
E                           'deobfuscation_status': 'deobfuscated',
E                       },
E                       'name': 'onClickHandler',
E                       'signature': '()',
E                       'source_file': 'MainActivity.java',
E                       'source_line': 40,
E                   },
E                   {
E                       'class_name': 'io.sentry.sample.MainActivity',
E                       'data': {
E                           'deobfuscation_status': 'deobfuscated',
E                       },
E                       'name': 'foo',
E                       'signature': '()',
E                       'source_file': 'MainActivity.java',
E                       'source_line': 44,
E                   },
E                   {
E                       'class_name': 'io.sentry.sample.MainActivity',
E                       'data': {
... (14 more lines)

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

Backend Test Failures

Failures on 686ae00 in this run:

tests/sentry/spans/test_buffer.py::test_hdel_redirect_map_batch_size[2-3]log
tests/sentry/spans/test_buffer.py:1316: in test_hdel_redirect_map_batch_size
    assert len(batch_sizes_seen) == expected_batches
E   assert 4 == 3
E    +  where 4 = len([2, 2, 2, 100])
tests/sentry/spans/test_buffer.py::test_hdel_redirect_map_batch_size[5-1]log
tests/sentry/spans/test_buffer.py:1316: in test_hdel_redirect_map_batch_size
    assert len(batch_sizes_seen) == expected_batches
E   assert 2 == 1
E    +  where 2 = len([5, 100])
tests/sentry/spans/test_buffer.py::test_hdel_redirect_map_batch_size[3-2]log
tests/sentry/spans/test_buffer.py:1316: in test_hdel_redirect_map_batch_size
    assert len(batch_sizes_seen) == expected_batches
E   assert 3 == 2
E    +  where 3 = len([3, 3, 100])

@armenzg armenzg merged commit 6338bf6 into master Mar 10, 2026
77 of 83 checks passed
@armenzg armenzg deleted the cursor/sentry-profiles-test-path-ef5d branch March 10, 2026 17:36
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants