test(symbolicator): Run Sentry tests tagged with symbolicator#110336
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
armenzg
approved these changes
Mar 10, 2026
joshuarli
reviewed
Mar 10, 2026
| python3 -b -m pytest tests/symbolicator --reuse-db -vv --junit-xml=.artifacts/symbolicator.junit.xml -o junit_suite_name=symbolicator | ||
| python3 -b -m pytest tests/relay_integration/lang/javascript/ --reuse-db -vv -m symbolicator | ||
| python3 -b -m pytest tests/relay_integration/lang/java/ --reuse-db -vv -m symbolicator | ||
| # All Sentry tests tagged with Symbolicator |
Member
There was a problem hiding this comment.
now that i'm looking at this file we should combine all these into a single pytest command - starting up sentry and collecting tests has nontrivial costs - we're probably leaving ~15-30s on the table here and we also have an optimization on --reuse-db in ci but it assumes only one pytest call per run
i'll commit that here and ensure the tests collected are the same
…est command Make requires_symbolicator imply pytest.mark.symbolicator so the marker is applied automatically wherever the fixture is used. This allows the Makefile test-symbolicator target to use a single pytest invocation with -m symbolicator instead of four separate commands. Remove now-redundant @pytest.mark.symbolicator decorators from all test files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The previous approach of nesting marks via `pytest.mark.symbolicator(pytest.mark.usefixtures(...))` doesn't work — pytest stores the inner mark as a positional arg rather than applying it as a separate mark, silently losing the fixture availability check. Instead, add a pytest_collection_modifyitems hook that automatically adds the `symbolicator` marker to any test using the `_requires_symbolicator` fixture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joshuarli
force-pushed
the
dav1d/test-run-symbolicator-tests
branch
from
91f932b to
ec728bf
Compare
jjbayer
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to proguard processing broke CI recently: https://github.com/getsentry/sentry/actions/runs/22902803288/job/66453716070#step:6:1335
There are symbolicator tests in Sentry itself, we can also run them in the Symbolicator CI.