(span-repro): add metric to track hypothetical data loss#110364
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
victoria-yining-huang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from this linear ticket, part of span buffer quality investigations. This is a silent failure mode where due to a variety of reasons (including consumer backpressure), when metadata that's used for outcomes and span data expire at the same time in redis, spans are dropped from redis and not processed, nor tracked in outcomes.
This is part 1 of a series of PR to investigate this silent failure mode.
below was removed after syncing with @untitaker
[ ] PR 2: adds alerting as I believe this requires immediate attention when it happens. A potential hotfix would be extending all TTL by 2x at the cost of more redis memory~~[ ] maybe PR 3 (long-term fix, tbd): maybe implement backpressure earlier? so stop writing to Redis when segments are close to expiring, give the flusher time to catch up.~~