Dependency on get_username in order to generate accounts with social auth.#1104
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
The sentry.utils.social_auth.create_user_if_enabled module calls create_user. If no username is set, it dies:
def create_user(backend, details, response, uid, username, user=None, *args,
**kwargs):
"""Create user. Depends on get_username pipeline."""
if user:
return {'user': user}
if not username:
return None
Contributor
Author
|
Not sure why Travis is failing..closing and reopening. |
Contributor
Author
|
Tests seemed to have passed now? |
|
This fixed the bug for me as well! Any updates on why this isn't being merged? |
dcramer
added a commit
that referenced
this pull request
Mar 13, 2014
Dependency on get_username in order to generate accounts with social auth.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something get changed again that prevented accounts via OpenID to be generated.