Skip to content

Dependency on get_username in order to generate accounts with social auth.#1104

Merged
dcramer merged 1 commit into
getsentry:masterfrom
rogerhu:fix_social_auth
Mar 13, 2014
Merged

Dependency on get_username in order to generate accounts with social auth.#1104
dcramer merged 1 commit into
getsentry:masterfrom
rogerhu:fix_social_auth

Conversation

@rogerhu
Copy link
Copy Markdown
Contributor

@rogerhu rogerhu commented Jan 9, 2014

Something get changed again that prevented accounts via OpenID to be generated.

Comment thread src/sentry/conf/server.py
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentry.utils.social_auth.create_user_if_enabled module calls create_user. If no username is set, it dies:

def create_user(backend, details, response, uid, username, user=None, *args,
                **kwargs):
    """Create user. Depends on get_username pipeline."""
    if user:
        return {'user': user}
    if not username:
        return None

@rogerhu
Copy link
Copy Markdown
Contributor Author

rogerhu commented Jan 9, 2014

Not sure why Travis is failing..closing and reopening.

@rogerhu rogerhu closed this Jan 9, 2014
@rogerhu rogerhu reopened this Jan 9, 2014
@rogerhu
Copy link
Copy Markdown
Contributor Author

rogerhu commented Jan 15, 2014

Tests seemed to have passed now?

@RSO
Copy link
Copy Markdown

RSO commented Mar 12, 2014

This fixed the bug for me as well! Any updates on why this isn't being merged?

dcramer added a commit that referenced this pull request Mar 13, 2014
Dependency on get_username in order to generate accounts with social auth.
@dcramer dcramer merged commit cf64c9d into getsentry:master Mar 13, 2014
@dcramer
Copy link
Copy Markdown
Member

dcramer commented Mar 13, 2014

Thanks!

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants