Skip to content

fix(explore): add !has filter when drilling down into no value group #110404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsdeschenes merged 2 commits into from
Apr 13, 2026
Merged

fix(explore): add !has filter when drilling down into no value group #110404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73be391
fix(explore): add !has filter when drilling down into no value group
SafinMahmud Mar 11, 2026
35052bf
Merge branch 'master' into fix/explore-filter-reset-106948
nsdeschenes Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions static/app/views/explore/utils.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,31 @@ describe('viewSamplesTarget', () => {
},
});
});

it('drill down with no value group by uses !has filter', () => {
const location = LocationFixture();
const target = viewSamplesTarget({
location,
query: '',
fields: ['foo'],
groupBys: ['user.id'],
visualizes: [visualize],
sorts: [sort],
row: {
'user.id': undefined,
'count(span.duration)': 10,
},
projects,
});
expect(target).toMatchObject({
query: {
field: ['foo', 'span.duration'],
mode: 'samples',
query: '!has:user.id',
sort: ['-span.duration'],
},
});
});
});

describe('findSuggestedColumns', () => {
Expand Down
2 changes: 2 additions & 0 deletions static/app/views/explore/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ export function generateTargetQuery({
} else {
search.setFilterValues(groupBy, [value]);
}
} else if (!defined(value)) {
search.addFilterValue('!has', groupBy);
}
}
Comment on lines +324 to 326
Copy link
Copy Markdown
Contributor

@sentry sentry bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The generateTargetQuery function silently ignores numeric groupBy values when drilling down into samples, causing the drilldown to show unfiltered results instead of the expected filtered data.
Severity: MEDIUM

Suggested Fix

Add a generic handler to the generateTargetQuery function to process numeric values. This can be done by adding an else if (typeof value === 'number') block that appends the filter condition newQuery.push(${groupBy}:${value}); to the query, similar to how string values are handled.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/explore/utils.tsx#L324-L326

Potential issue: The `generateTargetQuery` function in
`static/app/views/explore/utils.tsx` lacks a handler for numeric values in `groupBy`
columns. While there are specific handlers for fields like `project.id` and a generic
handler for strings, any other numeric value (e.g., `http.status_code` or custom numeric
attributes) will fall through all conditions. Consequently, when a user groups by a
numeric attribute and clicks "View Samples", the numeric filter is silently skipped.
This leads to the samples page showing all spans instead of the correctly filtered
subset, which is incorrect and misleading behavior.

Did we get this right? 👍 / 👎 to inform future reviews.


Expand Down
Loading