Skip to content

fix(suspect-commits): Skip commit age filtering for demo/sandbox orgs#110493

Closed
maxkosty wants to merge 4 commits into
getsentry:masterfrom
maxkosty:demo-no-suspect-commit-age-filter
Closed

fix(suspect-commits): Skip commit age filtering for demo/sandbox orgs#110493
maxkosty wants to merge 4 commits into
getsentry:masterfrom
maxkosty:demo-no-suspect-commit-age-filter

Conversation

@maxkosty
Copy link
Copy Markdown
Contributor

@maxkosty maxkosty commented Mar 11, 2026

Goal

Makes sure that Suspect Commit comes up in demo/sandbox without needing to touch the erroring line every 2 months in every one of ~ 20 and counting individual demo apps by always picking the most recent blame commit regardless of it its age.

Implementation

doesn't seem like we have any existing constants for demo org ids/slugs

Testing

none

Related

https://github.com/getsentry/sentry-options-automator/pull/6804

@maxkosty maxkosty requested review from a team as code owners March 11, 2026 23:07
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 11, 2026
Comment thread src/sentry/integrations/utils/commit_context.py Outdated
Copy link
Copy Markdown
Member

@nora-shap nora-shap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment from cursor is valid - these ids should live in options. There is already an option for demo-mode.orgs that you can use instead of DEMO_SANDBOX_ORG_IDS

@maxkosty
Copy link
Copy Markdown
Contributor Author

I think the comment from cursor is valid - these ids should live in options. There is already an option for demo-mode.orgs that you can use instead of DEMO_SANDBOX_ORG_IDS

I'll add a new option then. demo-mode == sandbox, it's different

@maxkosty maxkosty force-pushed the demo-no-suspect-commit-age-filter branch from 74ba7cd to 2994633 Compare March 12, 2026 19:54
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread src/sentry/options/defaults.py
Demo and sandbox orgs use synthetic data where blame commits may fall
outside the 60-day window. Always pick the most recent blame commit
for these orgs so suspect commits still surface.

The org IDs are stored in the `demo-mode.demo-and-sandbox-org-ids`
option so they can be changed at runtime.

Made-with: Cursor
@maxkosty maxkosty force-pushed the demo-no-suspect-commit-age-filter branch from c33b1b5 to a137f44 Compare March 12, 2026 20:06
@maxkosty maxkosty requested a review from nora-shap March 12, 2026 20:18
@maxkosty maxkosty added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Mar 12, 2026
@github-actions github-actions Bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Mar 12, 2026
@jeffrey-sentry jeffrey-sentry added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Mar 13, 2026
@maxkosty
Copy link
Copy Markdown
Contributor Author

Reopening from getsentry:demo-no-suspect-commit-age-filter (now have push access to the parent repo).

@maxkosty maxkosty closed this Mar 17, 2026
maxkosty added a commit that referenced this pull request Mar 17, 2026
…#110935)

# Goal

Makes sure that Suspect Commit comes up in demo/sandbox without needing
to touch the erroring line every 2 months in every one of ~ 20 and
counting individual demo apps by always picking the most recent blame
commit regardless of its age.

# Implementation
doesn't seem like we have any existing constants for demo org ids/slugs
`demo-mode` is for very specific sandbox hacks (read-only org +
`sandbox` pulls artifacts from `demo` org)

# Testing 
none

# Related
getsentry/sentry-options-automator#6804

---

Continuation of #110493 (reopened from `getsentry` branch instead of
fork).
JonasBa pushed a commit that referenced this pull request Mar 18, 2026
…#110935)

# Goal

Makes sure that Suspect Commit comes up in demo/sandbox without needing
to touch the erroring line every 2 months in every one of ~ 20 and
counting individual demo apps by always picking the most recent blame
commit regardless of its age.

# Implementation
doesn't seem like we have any existing constants for demo org ids/slugs
`demo-mode` is for very specific sandbox hacks (read-only org +
`sandbox` pulls artifacts from `demo` org)

# Testing 
none

# Related
getsentry/sentry-options-automator#6804

---

Continuation of #110493 (reopened from `getsentry` branch instead of
fork).
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants