fix(suspect-commits): Skip commit age filtering for demo/sandbox orgs#110493
fix(suspect-commits): Skip commit age filtering for demo/sandbox orgs#110493maxkosty wants to merge 4 commits into
Conversation
nora-shap
left a comment
There was a problem hiding this comment.
I think the comment from cursor is valid - these ids should live in options. There is already an option for demo-mode.orgs that you can use instead of DEMO_SANDBOX_ORG_IDS
I'll add a new option then. demo-mode == sandbox, it's different |
74ba7cd to
2994633
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Demo and sandbox orgs use synthetic data where blame commits may fall outside the 60-day window. Always pick the most recent blame commit for these orgs so suspect commits still surface. The org IDs are stored in the `demo-mode.demo-and-sandbox-org-ids` option so they can be changed at runtime. Made-with: Cursor
c33b1b5 to
a137f44
Compare
|
Reopening from getsentry:demo-no-suspect-commit-age-filter (now have push access to the parent repo). |
…#110935) # Goal Makes sure that Suspect Commit comes up in demo/sandbox without needing to touch the erroring line every 2 months in every one of ~ 20 and counting individual demo apps by always picking the most recent blame commit regardless of its age. # Implementation doesn't seem like we have any existing constants for demo org ids/slugs `demo-mode` is for very specific sandbox hacks (read-only org + `sandbox` pulls artifacts from `demo` org) # Testing none # Related getsentry/sentry-options-automator#6804 --- Continuation of #110493 (reopened from `getsentry` branch instead of fork).
…#110935) # Goal Makes sure that Suspect Commit comes up in demo/sandbox without needing to touch the erroring line every 2 months in every one of ~ 20 and counting individual demo apps by always picking the most recent blame commit regardless of its age. # Implementation doesn't seem like we have any existing constants for demo org ids/slugs `demo-mode` is for very specific sandbox hacks (read-only org + `sandbox` pulls artifacts from `demo` org) # Testing none # Related getsentry/sentry-options-automator#6804 --- Continuation of #110493 (reopened from `getsentry` branch instead of fork).

Goal
Makes sure that Suspect Commit comes up in demo/sandbox without needing to touch the erroring line every 2 months in every one of ~ 20 and counting individual demo apps by always picking the most recent blame commit regardless of it its age.
Implementation
doesn't seem like we have any existing constants for demo org ids/slugs
Testing
none
Related
https://github.com/getsentry/sentry-options-automator/pull/6804