chore(webhooks): Include tags by default#110519
Merged
Merged
Conversation
…ests This commit removes the `hybridcloud.deliver_webhooks.delivery_time_include_github_tags` option from the `DeliveryTimeMetricsTest` class, simplifying the tests for delivery time metrics related to GitHub events. The logic for including GitHub tags has been integrated directly into the `_record_delivery_time_metrics` function, ensuring consistent behavior without the need for the option in the tests.
github-actions
Bot
added
the
Scope: Backend
joseph-sentry
approved these changes
Mar 12, 2026
| tags = {"region_sent_to": region_sent_to} | ||
| if options.get("hybridcloud.deliver_webhooks.delivery_time_include_github_tags"): | ||
| tags |= _get_github_delivery_time_tags(payload) | ||
| tags = {"region_sent_to": region_sent_to} | _get_github_delivery_time_tags(payload) |
Contributor
There was a problem hiding this comment.
[nit] what if we wrapped this call in a try-except in case there's an error that would only show up when this function is called in non control silo context
Member
Author
There was a problem hiding this comment.
I can't see how as this has been running in production without any issues.
markstory
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for including GitHub tags has been integrated directly into the
_record_delivery_time_metricsfunction, ensuring consistent behavior without the need for the option in the tests.