Conversation
Add the organizations:onboarding-scm feature flag to gate the new SCM-first onboarding flow. Uses FLAGPOLE strategy with api_expose=True so the frontend can check the flag. Refs VDY-18 Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Mar 12, 2026
jaydgoss
deleted the
jaygoss/vdy-18-add-feature-flag-and-scaffold-scm-onboarding-steps-with
branch
jaydgoss
added a commit
that referenced
this pull request
Mar 17, 2026
…110747) Scaffold the frontend onboarding step array for the SCM-first onboarding flow behind the `organizations:onboarding-scm` feature flag. When enabled, the onboarding shows 5 steps instead of the legacy 3, with placeholder components for each new step that just render a heading and Continue button. The feature flag was registered in #110570. This PR adds the frontend wiring: - Three new `OnboardingStepId` enum values (`SCM_CONNECT`, `SCM_PLATFORM_FEATURES`, `SCM_PROJECT_DETAILS`) - Conditional step array selection based on the feature flag - Placeholder step components (`ScmConnect`, `ScmPlatformFeatures`, `ScmProjectDetails`) - Extended `OnboardingContext` with `selectedIntegration`, `selectedRepositories`, and `selectedFeatures` state (session storage backed) - Updated `useBackActions` to accept `onboardingSteps` as a parameter instead of importing the now-conditional module-level constant - Fixed `goNextStep` to allow navigation to SETUP_DOCS when platform is set via context (needed for the SCM flow where platform selection happens in an earlier step) - Replaced fragile index-based step lookups (`onboardingSteps[2]`) with `OnboardingStepId` enum references With the flag off, behavior is unchanged (existing tests all pass). Refs VDY-18 --------- Co-authored-by: Claude Opus 4.6 <noreply@example.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
organizations:onboarding-scmfeature flag intemporary.pywith FLAGPOLE strategy andapi_expose=TrueCompanion PR
Test plan
features.has("organizations:onboarding-scm", org, actor=user)organization.features.includes('onboarding-scm')Refs VDY-18