fix(tracemetrics): Preserve all visualizes when changing chart type#110618
Merged
nsdeschenes merged 1 commit intomasterfrom Mar 13, 2026
Merged
Conversation
handleChartTypeChange was using useSetMetricVisualize (singular) which replaced the entire visualizes array with only the first visualize, dropping all other aggregate selections. Switch to useSetMetricVisualizes (plural) and map over all visualizes to update the chart type on each. Fixes LOGS-607 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
nsdeschenes
changed the title
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
DominikB2014
approved these changes
Mar 13, 2026
nsdeschenes
deleted the
nd/LOGS-607/fix-logs-keep-all-aggregate-selections-changing-chart-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the chart type (line/area/bar) in the metrics view was dropping all aggregate/visualization selections except the first one.
handleChartTypeChangecalleduseSetMetricVisualize(singular), which replaced the entire visualizes array with a single-element array containing only the updated first visualize. Switching touseSetMetricVisualizes(plural) and mapping over all visualizes preserves the full list while updating the chart type on each.Fixes LOGS-607