ref: migrate remaining non-component default export values to named by JoshuaKGoldberg · Pull Request #110630 · getsentry/sentry

JoshuaKGoldberg · 2026-03-13T14:18:08Z

Splits out the source & test changes from #110517. That PR expands the no-default-export-components lint rule to apply to non-component-likes and renames it to no-default-exports.

The lint rule expansion itself is in #110631.

In static/app excluding mocks, this reduces:

export default \w+: from ~900 to ~800
import \w+ from: from ~5.8k to ~5.6k

Fixes ENG-7040.

linear-code · 2026-03-13T14:18:14Z

ENG-7040 Convert straightforward non-component default export values to named

github-actions · 2026-03-13T14:18:31Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

static/app/utils/recreateRoute.tsx

JoshuaKGoldberg · 2026-03-13T15:27:08Z

src/sentry/management/commands/generate_controlsilo_urls.py

            ts_code = f"""// This is generated code.
 // To update it run `getsentry django generate_controlsilo_urls --format=js --output=/path/to/thisfile.ts`
-const patterns: RegExp[] = [
+export const controlsiloUrlPatterns: RegExp[] = [


[Explanation] controlsiloUrlPatterns.ts is checked in and linted. We could either stop linting it or update this Python script that generates it.

we should probably do both.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Removing default fallback breaks unmigrated dynamic imports
- Restored the defensive fallback pattern to check module?.docs first, then module?.default, ensuring dynamically imported modules work regardless of export style.

Or push these changes by commenting:

@cursor push 0bca1bf0c1

Preview (0bca1bf0c1)

diff --git a/static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts b/static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts
--- a/static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts
+++ b/static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts
@@ -85,7 +85,10 @@
     refetch: projectKeys.refetch,
     isLoading: projectKeys.isPending || module === undefined,
     isError: projectKeys.isError,
-    docs: module === 'none' ? null : (module?.docs ?? null),
+    docs:
+      module === 'none'
+        ? null
+        : (module?.docs ?? (module as {default?: Docs<any>})?.default ?? null),
     dsn: projectKeys.data?.[0]?.dsn,
     projectKeyId: projectKeys.data?.[0]?.id,
   };

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts

JoshuaKGoldberg · 2026-03-13T15:29:13Z

static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts

-  const [module, setModule] = useState<undefined | 'none' | {default: Docs<any>}>(
-    undefined
-  );
+  const [module, setModule] = useState<undefined | 'none' | {docs: Docs<any>}>(undefined);


[Explanation] This fun little oddity imports modules in a way neither TypeScript nor Rspack/Webpack appreciate:

sentry/static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts

Lines 66 to 70 in 555a3ea

const mod = await import(

/* webpackExclude: /.spec/ */

`sentry/gettingStartedDocs/${platform.id}`

);

setModule(mod);

Tl;dr (see the next change in the file): the modules were previously allowed to have either .default or .docs. I removed all the .defaults so now it's just .docs.

for the future: is there a way to do this in a not-so-dynamic way? knip is also struggling with this, which is why we have this exception:

sentry/knip.config.ts

Lines 12 to 13 in c1887e1

// very dynamically imported

'static/app/gettingStartedDocs/**/*.{js,ts,tsx}',

We also need to know that we have to export a docs const, if we export something else it will not yield a compile time error.

I guess a huge exhaustive switch statement would work, but maybe you know of something better?

That's just about what I'd do 😞 a big switch statement or an equivalent well-typed object. If we were on Vite we could so something like an import.glob, or in Webpack-land maybe a require.context / webpackInclude might work. But in general trying to base anything in builder+types-land based on file system details is just a weirdness to me.

TkDodo · 2026-03-17T10:10:11Z

src/sentry/management/commands/generate_controlsilo_urls.py

            ts_code = f"""// This is generated code.
 // To update it run `getsentry django generate_controlsilo_urls --format=js --output=/path/to/thisfile.ts`
-const patterns: RegExp[] = [
+export const controlsiloUrlPatterns: RegExp[] = [


we should probably do both.

TkDodo · 2026-03-17T10:16:03Z

static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts

-  const [module, setModule] = useState<undefined | 'none' | {default: Docs<any>}>(
-    undefined
-  );
+  const [module, setModule] = useState<undefined | 'none' | {docs: Docs<any>}>(undefined);


for the future: is there a way to do this in a not-so-dynamic way? knip is also struggling with this, which is why we have this exception:

sentry/knip.config.ts

Lines 12 to 13 in c1887e1

// very dynamically imported

'static/app/gettingStartedDocs/**/*.{js,ts,tsx}',

We also need to know that we have to export a docs const, if we export something else it will not yield a compile time error.

I guess a huge exhaustive switch statement would work, but maybe you know of something better?

…t(-components) rule (#110631) Recreates specifically the lint rule expansion from #110517. This: * Removes `isReactComponentLike`, allowing the rule to operate on other values * Renames the rule from `no-default-export-components` to `no-default-exports` Note that the rule still only looks at "straightforward" exports: those where there's only a default export in a file, not any named ones. In `static/app` excluding mocks, this reduces: * `export default \w+`: from ~900 to ~800 * `import \w+ from`: from ~5.8k to ~5.6k Stacked on #110630, which applies the rest of the changes from #110517. Fixes ENG-7049

github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 13, 2026

JoshuaKGoldberg mentioned this pull request Mar 13, 2026

feat(eslint): remove component-like restriction from no-default-export(-components) rule #110631

Merged

vercel bot deployed to Preview March 13, 2026 14:19 View deployment

JoshuaKGoldberg force-pushed the lint-no-default-exports-values-fixes branch from 5b5a713 to 09b41bc Compare March 13, 2026 14:23

vercel bot deployed to Preview March 13, 2026 14:26 View deployment

JoshuaKGoldberg marked this pull request as ready for review March 13, 2026 15:24

JoshuaKGoldberg requested review from a team as code owners March 13, 2026 15:24

cursor bot reviewed Mar 13, 2026

View reviewed changes

static/app/utils/recreateRoute.tsx Outdated Show resolved Hide resolved

JoshuaKGoldberg force-pushed the lint-no-default-exports-values-fixes branch from 09b41bc to d3ab52c Compare March 13, 2026 15:26

JoshuaKGoldberg commented Mar 13, 2026

View reviewed changes

cursor bot reviewed Mar 13, 2026

View reviewed changes

static/app/components/onboarding/gettingStartedDoc/utils/useLoadGettingStarted.ts Show resolved Hide resolved

vercel bot deployed to Preview March 13, 2026 15:29 View deployment

JoshuaKGoldberg commented Mar 13, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

JoshuaKGoldberg force-pushed the lint-no-default-exports-values-fixes branch from d3ab52c to 81b4431 Compare March 16, 2026 14:32

vercel bot deployed to Preview March 16, 2026 14:35 View deployment

TkDodo approved these changes Mar 17, 2026

View reviewed changes

JoshuaKGoldberg force-pushed the lint-no-default-exports-values-fixes branch from 81b4431 to 0f5a72e Compare March 17, 2026 11:43

vercel bot deployed to Preview March 17, 2026 11:45 View deployment

JoshuaKGoldberg force-pushed the lint-no-default-exports-values-fixes branch from 0f5a72e to c63745e Compare March 17, 2026 12:08

vercel bot deployed to Preview March 17, 2026 12:11 View deployment

ref: migrate remaining non-component default export values to named

047ab50

JoshuaKGoldberg force-pushed the lint-no-default-exports-values-fixes branch from c63745e to 047ab50 Compare March 17, 2026 13:26

vercel bot deployed to Preview March 17, 2026 13:29 View deployment

JoshuaKGoldberg merged commit 38f683c into master Mar 17, 2026
61 checks passed

JoshuaKGoldberg deleted the lint-no-default-exports-values-fixes branch March 17, 2026 13:49

sentry-release-bot bot mentioned this pull request Mar 17, 2026

publish: getsentry/sentry@26.3.1 getsentry/publish#7498

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref: migrate remaining non-component default export values to named#110630

ref: migrate remaining non-component default export values to named#110630
JoshuaKGoldberg merged 1 commit intomasterfrom
lint-no-default-exports-values-fixes

JoshuaKGoldberg commented Mar 13, 2026 •

edited

Loading

Uh oh!

linear-code bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Uh oh!

JoshuaKGoldberg Mar 13, 2026

Uh oh!

TkDodo Mar 17, 2026

Uh oh!

cursor bot left a comment •

edited

Loading

Uh oh!

Uh oh!

JoshuaKGoldberg Mar 13, 2026

Uh oh!

TkDodo Mar 17, 2026

Uh oh!

JoshuaKGoldberg Mar 17, 2026

Uh oh!

This comment was marked as outdated.

TkDodo Mar 17, 2026

Uh oh!

TkDodo Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const mod = await import(
	/* webpackExclude: /.spec/ */
	`sentry/gettingStartedDocs/${platform.id}`
	);
	setModule(mod);

	// very dynamically imported
	'static/app/gettingStartedDocs/*/.{js,ts,tsx}',

Uh oh!

Conversation

JoshuaKGoldberg commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Uh oh!

JoshuaKGoldberg Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

TkDodo Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

TkDodo Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

TkDodo Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

TkDodo Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoshuaKGoldberg commented Mar 13, 2026 •

edited

Loading

cursor bot left a comment •

edited

Loading