fix(events): Don't link to trace explorer when trace id is missing#110670
Merged
fix(events): Don't link to trace explorer when trace id is missing#110670
Conversation
When an event has no trace id, the trace column in the events table still rendered a clickable link navigating to the trace explorer with a null trace id. Now the trace value renders as plain text without a link when no trace id is present. Also fix generateTraceLink converting null/undefined to the string "null"/"undefined" via template literal, bypassing the empty check. Refs LINEAR-ISWF-2234 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Simplify the trace link logic by guarding on dataRow.trace before calling generateTraceLink, rather than inspecting the target shape. Remove trace from the second mock event so the test fixture naturally covers both with-trace and without-trace cases. Refs LINEAR-ISWF-2234 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
scttcper
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an event has no trace id, the trace column in the events table still rendered a clickable link navigating to the trace explorer with a null trace id. Now the trace value renders as plain text without a link when no trace id is present.
Also fix generateTraceLink converting null/undefined to the string "null"/"undefined" via template literal, bypassing the empty check.
Refs ISWF-2234
Before: https://linear.app/getsentry/issue/ISWF-2234/dont-link-to-trace-explorer-if-no-trace-id-is-present
After:
