ref(spans): Remove zero-copy-dest-threshold option and SUNIONSTORE codepath#110759
Merged
ref(spans): Remove zero-copy-dest-threshold option and SUNIONSTORE codepath#110759
Conversation
github-actions
bot
added
the
Scope: Backend
Contributor
Backend Test FailuresFailures on
|
…depath The SMEMBERS+SADD path is now always used for merging Redis sets in the span buffer. SUNIONSTORE re-serialises the entire destination set on every call, making it O(destination + sources), while SMEMBERS+SADD is O(sources) only. The option was permanently set to 1 in production, so the branching logic and option are no longer needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
untitaker
force-pushed
the
untitaker/ref/remove-sunionstore-codepath
branch
from
ccf95a3 to
e71b1c0
Compare
evanh
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SMEMBERS+SADD path is now always used for merging Redis sets in the
span buffer. SUNIONSTORE re-serialises the entire destination set on
every call, making it O(destination + sources), while SMEMBERS+SADD is
O(sources) only. The option was permanently set to 1 in production,
so the branching logic and option are no longer needed.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com