ref(grouping): More parameterization metric improvements#110782
Merged
lobsterkatie merged 4 commits intomasterfrom Mar 17, 2026
Merged
ref(grouping): More parameterization metric improvements#110782lobsterkatie merged 4 commits intomasterfrom
lobsterkatie merged 4 commits intomasterfrom
Conversation
7791a92 to
f4d7450
Compare
f4d7450 to
503ddb2
Compare
nora-shap
approved these changes
Mar 17, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #110612, making a few more improvements to our message parameterization metrics.
Until recently, message parameterization was only ever the result of a call to
normalize_message_for_grouping, so timing that function was a good proxy for timing parameterization itself. However, in ref(grouping): Cache parameterization on context #110605 we changed it so that a)normalize_message_for_groupingno longer calls the parameterizer every time it runs (instead relying on a cached value), and b) the initial calculation of that cached value happens elsewhere.normalize_message_for_groupingstill can call the parameterizer, but it now only does so in cases where it has to parameterize something other than the event's primary message (in the case of error chains, for example). Thus timing it is no longer a good way to measure how fast parameterization runs. This fixes that by adding a timer to the parameterization itself.With that timing metric in place, we no longer need the
parameterizer_calledmetric, because we can just use the timing metrics.countvalues to get the same information, so this removes it in favor of adding theexperimentalandchangedtags to the timer.Right now, parameterization can be tagged as being experimental even if the experimental parameterizer isn't actually any different than the default one. This fixes that by checking the two regex sets against each other before setting the parameterizer's
_experimentalattribute.