Skip to content

ref(grouping): More parameterization metric improvements#110782

Merged
lobsterkatie merged 4 commits intomasterfrom
kmclb-more-parameterization-metric-improvements
Mar 17, 2026
Merged

ref(grouping): More parameterization metric improvements#110782
lobsterkatie merged 4 commits intomasterfrom
kmclb-more-parameterization-metric-improvements

Conversation

@lobsterkatie
Copy link
Member

This is a follow-up to #110612, making a few more improvements to our message parameterization metrics.

  • Until recently, message parameterization was only ever the result of a call to normalize_message_for_grouping, so timing that function was a good proxy for timing parameterization itself. However, in ref(grouping): Cache parameterization on context #110605 we changed it so that a) normalize_message_for_grouping no longer calls the parameterizer every time it runs (instead relying on a cached value), and b) the initial calculation of that cached value happens elsewhere. normalize_message_for_grouping still can call the parameterizer, but it now only does so in cases where it has to parameterize something other than the event's primary message (in the case of error chains, for example). Thus timing it is no longer a good way to measure how fast parameterization runs. This fixes that by adding a timer to the parameterization itself.

  • With that timing metric in place, we no longer need the parameterizer_called metric, because we can just use the timing metrics .count values to get the same information, so this removes it in favor of adding the experimental and changed tags to the timer.

  • Right now, parameterization can be tagged as being experimental even if the experimental parameterizer isn't actually any different than the default one. This fixes that by checking the two regex sets against each other before setting the parameterizer's _experimental attribute.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 16, 2026
@lobsterkatie lobsterkatie force-pushed the kmclb-more-parameterization-metric-improvements branch from 7791a92 to f4d7450 Compare March 16, 2026 19:01
@lobsterkatie lobsterkatie force-pushed the kmclb-more-parameterization-metric-improvements branch from f4d7450 to 503ddb2 Compare March 16, 2026 19:49
@lobsterkatie lobsterkatie marked this pull request as ready for review March 16, 2026 21:28
@lobsterkatie lobsterkatie requested a review from a team as a code owner March 16, 2026 21:28
@lobsterkatie lobsterkatie merged commit 2e9fc77 into master Mar 17, 2026
82 of 84 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-more-parameterization-metric-improvements branch March 17, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants