feat(ACI): Handle owner passed to workflow

[ceorourke]

The Workflow model inherits the OwnerModel but the WorkflowValidator doesn't actually do anything if passed owner. This PR adds handling to the validator for the owner field so that it's saved and updated if passed. Thankfully the OwnerActorField handles all the validation needed. Tests are copied from the existing behavior in issue alert rules for creating and updating. API docs are updated (and fixed) to indicate that there can be an owner for detectors and workflows (externally, monitors and alerts).

[linear-code]

ISWF-2239 Save and update owner data on a Workflow

[saponifi3d]

lgtm - not quite sure why you're getting some of that type failure though, might just need to update from master to fix that, then the tests will need to be updated for the api docs.

thanks for implementing this so quickly 🙏

[cursor]

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

[cursor]

UnboundLocalError when owner is not user or team

Medium Severity

In update_owner, if owner is truthy but neither is_user nor is_team, the if/elif branches are both skipped, and owner_user_id and owner_team_id are never assigned. The return statement on line 32 then raises an UnboundLocalError. An else clause within the if owner: block (or initializing the variables before the conditional) would prevent this.

 

[github-actions]

Backend Test Failures

Failures on fd5704f in this run:

tests/sentry/workflow_engine/endpoints/validators/test_base_workflow.py::TestWorkflowValidatorUpdate::test_update_owner_type — log

.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'owner'

During handling of the above exception, another exception occurred:
tests/sentry/workflow_engine/endpoints/validators/test_base_workflow.py:828: in test_update_owner_type
    workflow = validator.update(self.workflow, validator.validated_data)
src/sentry/workflow_engine/endpoints/validators/base/workflow.py:262: in update
    instance.update(**validated_data)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: Workflow has no field named 'owner'

tests/sentry/workflow_engine/endpoints/validators/test_base_workflow.py::TestWorkflowValidatorUpdate::test_reassign_owner_from_own_team_to_any_team — log

.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'owner'

During handling of the above exception, another exception occurred:
tests/sentry/workflow_engine/endpoints/validators/test_base_workflow.py:898: in test_reassign_owner_from_own_team_to_any_team
    workflow = validator.update(self.workflow, validator.validated_data)
src/sentry/workflow_engine/endpoints/validators/base/workflow.py:262: in update
    instance.update(**validated_data)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: Workflow has no field named 'owner'

tests/sentry/workflow_engine/endpoints/validators/test_base_workflow.py::TestWorkflowValidatorUpdate::test_team_owner_not_member_with_team_admin_scope — log

.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'owner'

During handling of the above exception, another exception occurred:
tests/sentry/workflow_engine/endpoints/validators/test_base_workflow.py:869: in test_team_owner_not_member_with_team_admin_scope
    workflow = validator.update(self.workflow, validator.validated_data)
src/sentry/workflow_engine/endpoints/validators/base/workflow.py:262: in update
    instance.update(**validated_data)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: Workflow has no field named 'owner'