feat(tracemetrics): Remove tracemetric from state#110786
Merged
narsaynorath merged 5 commits intomasterfrom Mar 17, 2026
Merged
feat(tracemetrics): Remove tracemetric from state#110786narsaynorath merged 5 commits intomasterfrom
narsaynorath merged 5 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgetBuilder/components/visualize/traceMetrics/metricSelectRow.tsx
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/dashboards/widgetBuilder/components/visualize/traceMetrics/metricSelectRow.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgetBuilder/components/visualize/traceMetrics/metricSelectRow.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
static/app/views/dashboards/widgetBuilder/components/visualize/traceMetrics/metricSelectRow.tsx
Outdated
Show resolved
Hide resolved
edwardgou-sentry
approved these changes
Mar 17, 2026
narsaynorath
deleted the
nar/feat/tracemetrics-remove-tracemetric-from-state
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceMetricattribute from state and URLs for widget builder. When a widget is saved, this data is flattened into the aggregates and then parsed up for the widget builder, but since I changed the type of aggregates to account for more parameters in: #109899 then we're able to remove the layer of indirection here where we need to parse out thetraceMetricfrom state and URLsThis is in preparation of being able to select multiple metrics in a single request. We can't be reliant on a top level parameter like this if we want to be dynamic.
The relevant validation and code that was in use for the aggregate selection now can be pushed out further to the metric selector since it's specific to that component.