Conversation
…table Use the Text component with the ellipsis prop in CellName instead of manually applying overflow CSS on the styled link. This ensures names are truncated with an ellipsis rather than overflowing their column. Fixes DAIN-1354 Co-Authored-By: Claude <noreply@anthropic.com>
…ard table Apply the same Text ellipsis fix to the legacy GridEditable-based DashboardTable, which renders when the dashboards-starred-reordering flag is off. Fixes DAIN-1354 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The query name is now rendered inside a Text component wrapping a Link,
so findByText() returns the outer span rather than the anchor element.
Switch to findByRole('link', {name}) to correctly target the <a> element
and assert its href attribute.
Co-Authored-By: Claude <noreply@anthropic.com>
Same fix as the savedQueriesTable tests — the name cell now renders
a Text wrapper around the Link, so getByText() returns the span rather
than the anchor. Switch to getByRole('link', {name}) to target the
correct element when asserting href.
Co-Authored-By: Claude <noreply@anthropic.com>
…mes-overflow-the-container-in-list-view
The original StyledLink in savedEntityTable.tsx already handled overflow with text-overflow: ellipsis, so those changes were unnecessary. The actual bug was only in dashboardTable.tsx. Revert savedEntityTable.tsx, savedQueriesTable.spec.tsx, and issueViewsList.spec.tsx to master.
edwardgou-sentry
approved these changes
Mar 18, 2026
DominikB2014
approved these changes
Mar 18, 2026
gggritso
deleted the
georgegritsouk/dain-1354-long-dashboard-names-overflow-the-container-in-list-view
branch
JonasBa
pushed a commit
that referenced
this pull request
Mar 18, 2026
…t view (#110828) Fixes long dashboard names overflowing their column in the dashboard list view. **Before:** <img width="602" height="89" alt="Screenshot 2026-03-17 at 4 17 15 PM" src="https://github.com/user-attachments/assets/93ae189e-0c96-4639-a8af-0e299e63a422" /> **After:** <img width="645" height="81" alt="Screenshot 2026-03-17 at 4 17 12 PM" src="https://github.com/user-attachments/assets/99f2c31e-a12e-4b14-86e7-eeff108db610" /> Fixes DAIN-1354 Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes long dashboard names overflowing their column in the dashboard list view.
Before:
After:
Fixes DAIN-1354
Co-Authored-By: Claude noreply@anthropic.com