fix(seer): Handle empty response in SCM integrations query#110836
Merged
fix(seer): Handle empty response in SCM integrations query#110836
Conversation
When the backend returns 204 with no body, the integrations API response is undefined. Add a nullish coalescing fallback so scmIntegrations is always an array, removing the need for optional chaining on subsequent operations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
vgrozdanic
approved these changes
Mar 17, 2026
shellmayr
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle empty response in primary nav Seer config reminder
When the integrations API returns a 204 with no body,
dataisundefined.The previous code left
scmIntegrationsasundefined | Integration[],requiring optional chaining (
?.some,&&length checks) throughout thehook. This adds a
?? []fallback soscmIntegrationsis always an array,simplifying downstream checks.
#inc-2083