feat(dashboards): Adds validation completion hook to generate dashboards endpoint#110903
Merged
edwardgou-sentry merged 7 commits intomasterfrom Mar 18, 2026
Merged
Conversation
…enerate-dashboard-artifact-improvement
…on and regenerate dashboard
…enerate-dashboard-completion-hook
Contributor
Backend Test FailuresFailures on
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
DominikB2014
approved these changes
Mar 18, 2026
JonasBa
pushed a commit
that referenced
this pull request
Mar 18, 2026
…rds endpoint (#110903) Right now, the validators on the dashboard artifacts are not actually used (they're run in post, but we don't use the validation result). Adds a completion hook to `OrganizationDashboardGenerateEndpoint`. Whenever a seer run for generating a dashboard is complete, checks the result dashboard artifact for any validation errors detected. If errors are detected, re request dashboard generation. This dashboard generation re request only happens up to 3 times (determined by `MAX_VALIDATION_RETRIES`) on consecutive failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Right now, the validators on the dashboard artifacts are not actually used (they're run in post, but we don't use the validation result).
Adds a completion hook to
OrganizationDashboardGenerateEndpoint. Whenever a seer run for generating a dashboard is complete, checks the result dashboard artifact for any validation errors detected. If errors are detected, re request dashboard generation.This dashboard generation re request only happens up to 3 times (determined by
MAX_VALIDATION_RETRIES) on consecutive failures.