Skip to content

chore(experiments): Add function to ExperimentMode to get assignment group#110932

Merged
wedamija merged 1 commit intomasterfrom
danf/experiment-mode-assignment-mapping
Mar 18, 2026
Merged

chore(experiments): Add function to ExperimentMode to get assignment group#110932
wedamija merged 1 commit intomasterfrom
danf/experiment-mode-assignment-mapping

Conversation

@wedamija
Copy link
Member

Just consolidating this logic here.

…t group

Just consolidating this logic here.
@wedamija wedamija requested a review from a team March 17, 2026 21:55
@wedamija wedamija requested review from a team as code owners March 17, 2026 21:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 17, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Member

@jaydgoss jaydgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor suggestion: consider adding a default case to the match so this doesn't silently return None if a new ExperimentMode variant is added later:

case _ as unreachable:
    assert_never(unreachable)

or just a raise ValueError. Not blocking.

@wedamija wedamija merged commit 994149b into master Mar 18, 2026
55 checks passed
@wedamija wedamija deleted the danf/experiment-mode-assignment-mapping branch March 18, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants