fix(worklows): More accurate legacy model use tracking#110934
Merged
Conversation
ceorourke
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Missing legacy tracking in combined rules legacy path
- Added the missing report_used_legacy_models() call after AlertRule.objects.fetch_for_organization() in the OrganizationCombinedRuleIndexEndpoint legacy path to match the fix applied to fetch_metric_alerts().
Or push these changes by commenting:
@cursor push e4732b1061
Preview (e4732b1061)
diff --git a/src/sentry/incidents/endpoints/organization_alert_rule_index.py b/src/sentry/incidents/endpoints/organization_alert_rule_index.py
--- a/src/sentry/incidents/endpoints/organization_alert_rule_index.py
+++ b/src/sentry/incidents/endpoints/organization_alert_rule_index.py
@@ -625,6 +625,7 @@
# Legacy path below
alert_rules = AlertRule.objects.fetch_for_organization(organization, projects)
+ report_used_legacy_models()
issue_rules = Rule.objects.filter(
status__in=[ObjectStatus.ACTIVE, ObjectStatus.DISABLED],This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


These rely on serializers, but there are clear legacy model usage paths, and by tagging them directly we avoid counting 0 result calls as not using legacy models.